Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First day of a week #1941

Closed
S3Y3D opened this issue Mar 28, 2020 · 2 comments
Closed

First day of a week #1941

S3Y3D opened this issue Mar 28, 2020 · 2 comments
Labels
good first issue Beginner-friendlish issue to start contributing

Comments

@S3Y3D
Copy link

S3Y3D commented Mar 28, 2020 •
edited

Hi,
First day of a week in some countries in middle east is SATURDAY.
please add this to the Android App.
@S3Y3D S3Y3D changed the title First day of a week [Android] First day of a week Mar 28, 2020
@nvhaver
Copy link

nvhaver commented Mar 28, 2020 •
edited

Hi,

I would also like to see this feature implemented. It seems that this feature is not only missing in the Android app but in the underlying Electron app.

I identified the following sections of the code to be updated:

Note that I'm not familiar with the project at all and thus have no view on which other parts of the code would be impacted (e.g. possible changes in the UI or other code that depends on the enum)...

Love the project, keep up the good work!

@vitoreiji vitoreiji added the good first issue Beginner-friendlish issue to start contributing label Mar 30, 2020
@charlag
Copy link
Contributor

charlag commented Mar 30, 2020

We don't accept feature requests here normally but we will discuss that

divarre added a commit to divarre/tutanota that referenced this issue Apr 14, 2020
@divarre
Add Saturday to week start options - Fix tutao#1941
5d6d1d4
divarre added a commit to divarre/tutanota that referenced this issue Apr 14, 2020
@divarre
Add Saturday to week start options - Fix tutao#1941
f0eca5f 
- add the ability to display calendar with Saturday being the first day of the week
- rename firstDayOfWeekFromSundayOffset to firstDayOfWeekFromOffset for clarity as Saturday can be an offset
- add Saturday as an option in the Appearance Settings
- add comment to clarify how names of the days are generated
@charlag charlag changed the title [Android] First day of a week First day of a week Apr 30, 2020
@S3Y3D S3Y3D closed this as completed May 15, 2020
vitoreiji pushed a commit that referenced this issue May 20, 2020
@divarre @vitoreiji
Add Saturday to week start options - Fix #1941
3b021b3 
- add the ability to display calendar with Saturday being the first day of the week
- rename firstDayOfWeekFromSundayOffset to firstDayOfWeekFromOffset for clarity as Saturday can be an offset
- add Saturday as an option in the Appearance Settings
- add comment to clarify how names of the days are generated
charlag pushed a commit that referenced this issue May 29, 2020
@divarre @charlag
Add Saturday to week start options - Fix #1941
07f4cba 
- add the ability to display calendar with Saturday being the first day of the week
- rename firstDayOfWeekFromSundayOffset to firstDayOfWeekFromOffset for clarity as Saturday can be an offset
- add Saturday as an option in the Appearance Settings
- add comment to clarify how names of the days are generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Beginner-friendlish issue to start contributing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vitoreiji @charlag @nvhaver @S3Y3D