Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit signature size #2573

Closed
vaf-hub opened this issue Jan 4, 2021 · 5 comments · Fixed by #2587
Closed

Limit signature size #2573

vaf-hub opened this issue Jan 4, 2021 · 5 comments · Fixed by #2587
Assignees
Labels
improvement nice-to-haves that are not impeding usage of any features small improvement A small improvement which can hopefully be implemented within a short time frame. state:tested We tested it and are about to release it
Milestone

Comments

@vaf-hub
Copy link
Contributor

vaf-hub commented Jan 4, 2021

We should have a limit on how large an email signature can be. At the very least we should show a warning if a large signature is configured.

It does not make sense to have large signatures, e.g. with embedded base64 images, but those should reference other sources.

@vaf-hub vaf-hub added the improvement nice-to-haves that are not impeding usage of any features label Jan 4, 2021
@vaf-hub vaf-hub added this to the Next release milestone Jan 4, 2021
@charlag
Copy link
Contributor

charlag commented Jan 4, 2021

Currently base64 images is the only way to embed images into signatures. I don't know if having external images is a good idea.

@vaf-hub
Copy link
Contributor Author

vaf-hub commented Jan 4, 2021

OK, anyway I think we should have a reasonable size limit to prevent people from sending large images with every single email. Our Tutanota logo is a little over 7kb as b64 image for instance. What do you think?

@charlag
Copy link
Contributor

charlag commented Jan 4, 2021

is it 7kb for svg or png? seems quire a lot but I don't know what's the average size for image in signature.
Ideally we would do files instead but it would also be limited.

@vaf-hub
Copy link
Contributor Author

vaf-hub commented Jan 5, 2021

after a discussion we decided to show a warning when setting up a large signature (>20kb?) but have no hard limit, because we already have a hard limit on the size of mails.

the warning should explain that it is not a good idea to send a large signature with every single email and fill the recipients' mailboxes

@vaf-hub
Copy link
Contributor Author

vaf-hub commented Jan 5, 2021

decided to go with 15kb as soft signature size limit. because 20 really seems like a lot. we could go for 10 and see if we get a lot of complaints...

@vaf-hub vaf-hub modified the milestones: Next release, 3.80.3 Jan 5, 2021
@armhub armhub modified the milestones: 3.80.3, Next release Jan 6, 2021
@charlag charlag modified the milestones: Next release, 3.80.6 Jan 25, 2021
@bedhub bedhub modified the milestones: Next release, Small improvements Feb 16, 2021
@bedhub bedhub added the small improvement A small improvement which can hopefully be implemented within a short time frame. label Mar 17, 2021
@bedhub bedhub modified the milestones: Small improvements, Roadmap Mar 17, 2021
@bedhub bedhub modified the milestones: Roadmap, Next release Apr 16, 2021
@johnbotris johnbotris modified the milestones: Next release, 3.83.4 Apr 30, 2021
@johnbotris johnbotris assigned johnbotris and Pa7Hub and unassigned vaf-hub and johnbotris May 12, 2021
@johnbotris johnbotris added the state:tested We tested it and are about to release it label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement nice-to-haves that are not impeding usage of any features small improvement A small improvement which can hopefully be implemented within a short time frame. state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants