Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve email verification UI feedback #2642

Closed
johnbotris opened this issue Jan 21, 2021 · 8 comments
Closed

Improve email verification UI feedback #2642

johnbotris opened this issue Jan 21, 2021 · 8 comments
Labels
improvement nice-to-haves that are not impeding usage of any features state:not-testable "tested" for blind fixes or old code removal with no expected regressions
Milestone
3.84.0

Comments

@johnbotris
Copy link
Contributor

During signup, if the user clicks next while the email is still being verified, they get this popup:
Screenshot from 2021-01-21 10-55-51
And then nothing happens until they click ok and then have to click next again. This is a bit clunky. It should instead just be a progress dialog, and upon completion the user should then be taken to the next page if it is approved, otherwise a failed verification message should be shown.
@johnbotris johnbotris added the improvement nice-to-haves that are not impeding usage of any features label Jan 21, 2021
@giraffekey
Copy link

I would be interested in doing this for a bounty.

@johnbotris
Copy link
Contributor Author

We don't have a bounty program, but contributions are always welcome

@giraffekey
Copy link

I was thinking of Bountysource

@johnbotris johnbotris self-assigned this Jan 29, 2021
johnbotris added a commit that referenced this issue Jan 29, 2021
@johnbotris
show progress dialog when verifying email address on signup instead o…
174e7db 
…f error dialog, close #2642
@jowlo
Copy link
Contributor

jowlo commented Feb 8, 2021

@johnbotris do you want to make a PR out of it?

@johnbotris johnbotris mentioned this issue Feb 8, 2021
Closed
@johnbotris
Copy link
Contributor Author

@jowlo nice idea

@jowlo jowlo added this to the 3.83.8 milestone May 25, 2021
@jowlo jowlo linked a pull request May 25, 2021 that will close this issue
show progress dialog when verifying email address on signup #2688
Closed
@johnbotris
Copy link
Contributor Author

johnbotris commented May 25, 2021 •
edited

This was fixed by changes as part of #2559. Now the next button will not trigger anything while verification is busy

@jowlo
Copy link
Contributor

jowlo commented May 26, 2021

Test notes

  • check signup with unavailable address
  • check signup with available address

@sarashub sarashub self-assigned this May 26, 2021
@sarashub
Copy link
Contributor

Was made redundant.

@sarashub sarashub added the state:not-testable "tested" for blind fixes or old code removal with no expected regressions label May 26, 2021
@sarashub sarashub removed their assignment May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement nice-to-haves that are not impeding usage of any features state:not-testable "tested" for blind fixes or old code removal with no expected regressions
Projects
None yet
Milestone
3.84.0
Development

Successfully merging a pull request may close this issue.

show progress dialog when verifying email address on signup tutao/tutanota
4 participants
@jowlo @giraffekey @johnbotris @sarashub