Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side credit card validation does not check length of CVC correctly #2796

Closed
rosso-ptg opened this issue Mar 4, 2021 · 0 comments · Fixed by #2803
Closed

Client side credit card validation does not check length of CVC correctly #2796

rosso-ptg opened this issue Mar 4, 2021 · 0 comments · Fixed by #2803
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.82.8

Comments

@rosso-ptg
Copy link

rosso-ptg commented Mar 4, 2021 •
edited

Bug in web app

To Reproduce
Steps to reproduce the behavior:

  1. Go to Subscription
  2. Click on Upgrade, select a paid plan
  3. Enter valid credit card data with an invalid two digit CVC
  4. Hit Next -> Data is sent to server

Expected behavior
Data containing a CVC with the wrong length is handled by client-side validation, no network request is sent
@rosso-ptg rosso-ptg added the bug broken functionality, usability problems, unexpected errors label Mar 4, 2021
jowlo added a commit that referenced this issue Mar 8, 2021
@jowlo
Check CVC length
02c63c6 
fix #2796
@jowlo jowlo mentioned this issue Mar 8, 2021
Merged
@jowlo jowlo added this to the 3.82.8 - Bugfix milestone Mar 8, 2021
jowlo added a commit that referenced this issue Mar 9, 2021
@jowlo
Check CVC length
9685179 
fix #2796
jowlo added a commit that referenced this issue Mar 9, 2021
@jowlo
Check CVC length
1612f6e 
fix #2796
charlag pushed a commit that referenced this issue Mar 9, 2021
@jowlo @charlag
Check CVC length
ccb5b30 
fix #2796
@bedhub bedhub modified the milestones: 3.82.9 - Bugfix, 3.28.8 Mar 9, 2021
@bedhub bedhub added the state:tested We tested it and are about to release it label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.82.8
Development

Successfully merging a pull request may close this issue.

Check CVC length on payment data updat tutao/tutanota
3 participants
@rosso-ptg @jowlo @bedhub