Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve drag&drop experience #2850

Closed
bedhub opened this issue Mar 15, 2021 · 5 comments · Fixed by #2857 or #2902
Closed

Improve drag&drop experience #2850

bedhub opened this issue Mar 15, 2021 · 5 comments · Fixed by #2857 or #2902
Assignees
@charlag
Labels
desktop Desktop client related issues improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Milestone
3.82.15

Comments

@bedhub
Copy link
Contributor

bedhub commented Mar 15, 2021 •
edited

  1. change cursor icon when drag modifier key is pressed in mail list
  2. Enable drag & drop in SearchView
  3. Change image under cursor when dragging. e.g. msg or eml file icon.
  4. Check if file path to /tmp/.. can be removed

Screenshot from 2021-03-15 16-01-37
@bedhub bedhub added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Mar 15, 2021
@bedhub bedhub added this to the 3.83.0 milestone Mar 15, 2021
johnbotris added a commit that referenced this issue Mar 16, 2021
@johnbotris
Change cursor over maillist when drag and drop modifier is held, #2850
26bd5b6 
For some reason `cursor: grab` doesn't work in electron. Ideally we would set it to that, but `cursor: copy` seems good too
@johnbotris johnbotris mentioned this issue Mar 17, 2021
Merged
@johnbotris johnbotris linked a pull request Mar 17, 2021 that will close this issue
Improve visual feeback when doing export drag and drop #2857
Merged
charlag pushed a commit that referenced this issue Mar 30, 2021
@johnbotris @charlag
Change cursor over maillist when drag and drop modifier is held, #2850
744038a 
For some reason `cursor: grab` doesn't work in electron. Ideally we would set it to that, but `cursor: copy` seems good too
charlag added a commit that referenced this issue Mar 30, 2021
@charlag
Use image files for drag export icons, close #2850
3720bdd
charlag pushed a commit that referenced this issue Mar 30, 2021
@johnbotris @charlag
Change cursor over maillist when drag and drop modifier is held, #2850
7ac39a1 
For some reason `cursor: grab` doesn't work in electron. Ideally we would set it to that, but `cursor: copy` seems good too
charlag added a commit that referenced this issue Mar 30, 2021
@charlag
Use image files for drag export icons, close #2850
0462190
@johnbotris
Copy link
Contributor

testing

when doing export drag and drop:

  1. holding the modifier key will cause the cursor to change when hovering over the mail list
  2. dragging the mail will show an icon with the filetype that is being exported

@vaf-hub vaf-hub reopened this Apr 1, 2021
@vaf-hub vaf-hub closed this as completed Apr 1, 2021
@charlag charlag self-assigned this Apr 1, 2021
@charlag
Copy link
Contributor

charlag commented Apr 1, 2021

Export-drag does not work at all on mac. It starts the download (because there's progress bar) but then cursor just changes back and no file is attached.

@charlag charlag reopened this Apr 1, 2021
@johnbotris
Copy link
Contributor

@charlag has the download completed by the time you try to drop? could it be the case the icon somehow isn't loading properly?

@charlag
Copy link
Contributor

charlag commented Apr 1, 2021

@johnbotris that's what I thought but it doesn't do anything. I keep cursor inside window until progress disappears and then there's nothing. Nothing in the logs either. I can try to debug it later on.

@charlag
Copy link
Contributor

charlag commented Apr 1, 2021

My change for icon path broke it, the path to icon is incorrect

bedhub added a commit that referenced this issue Apr 1, 2021
@bedhub
[desktop] Fix drag-n-drop on mac, fix #2850
87a2d2c
charlag added a commit that referenced this issue Apr 1, 2021
@charlag
[desktop] Fix drag-n-drop on mac, fix #2850
351ea1d
@charlag charlag mentioned this issue Apr 1, 2021
Merged
johnbotris pushed a commit that referenced this issue Apr 6, 2021
@charlag @johnbotris
[desktop] Fix drag-n-drop on mac, fix #2850
29a1117
@charlag charlag added improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it and removed bug broken functionality, usability problems, unexpected errors labels Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
desktop Desktop client related issues improvement nice-to-haves that are not impeding usage of any features state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.82.15
4 participants
@charlag @bedhub @johnbotris @vaf-hub