Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: 'Download' embedded image opens, but does not save the image. #2925

Closed
ghost opened this issue Apr 9, 2021 · 2 comments · Fixed by #2935
Closed

Android: 'Download' embedded image opens, but does not save the image. #2925

ghost opened this issue Apr 9, 2021 · 2 comments · Fixed by #2935
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients state:tested We tested it and are about to release it
Milestone
3.84.0

Comments

@ghost
Copy link

ghost commented Apr 9, 2021

When the user long-taps an embedded image they are presented with a download option. The option will open the image, but does not save it locally.

To Reproduce
Steps to reproduce the behavior:

  1. Long-tap an embedded image
  2. Click on 'Download'
  3. Choose which application should open the file (Photos, Files, etc)
  4. If the image is then closed, it must be reopened from the email. It does not save a local copy to the device.

Smartphone(s):

  • Device: Pixel 3a, Nokia 7 Plus
  • OS: Android 11, Android 10
  • Tutanota 3.82.11
@ghost ghost added the bug broken functionality, usability problems, unexpected errors label Apr 9, 2021
johnbotris added a commit that referenced this issue Apr 12, 2021
@johnbotris
add option to just download inline images on long press, fix #2925
cad789b 
Also, change the positioning handling for the dropdown, so that it appears underneath the mouse, rather than below the image element
johnbotris added a commit that referenced this issue Apr 12, 2021
@johnbotris
add option to just download inline images on long press, fix #2925
da53f7e 
Also, change the positioning handling for the dropdown, so that it appears underneath the mouse, rather than below the image element
@johnbotris johnbotris mentioned this issue Apr 12, 2021
Merged
johnbotris added a commit that referenced this issue Apr 12, 2021
@johnbotris
add option to just download inline images on long press, fix #2925
5bb3234 
Also, change the positioning handling for the dropdown, so that it appears underneath the mouse, rather than below the image element
@johnbotris johnbotris added this to the 3.83.XX milestone Apr 16, 2021
@johnbotris johnbotris added android issues that concern the android client but not all clients desktop Desktop client related issues ios issues that concern the ios client but not all clients and removed desktop Desktop client related issues labels Apr 16, 2021
bedhub pushed a commit that referenced this issue Apr 21, 2021
@johnbotris @bedhub
add option to just download inline images on long press, fix #2925
74a6f59 
Also, change the positioning handling for the dropdown, so that it appears underneath the mouse, rather than below the image element
bedhub pushed a commit that referenced this issue Apr 21, 2021
@johnbotris @bedhub
add option to just download inline images on long press, fix #2925
a5e9729 
Also, change the positioning handling for the dropdown, so that it appears underneath the mouse, rather than below the image element
bedhub pushed a commit that referenced this issue Apr 21, 2021
@johnbotris @bedhub
add option to just download inline images on long press, fix #2925
630124e 
Also, change the positioning handling for the dropdown, so that it appears underneath the mouse, rather than below the image element
@johnbotris
Copy link
Contributor

johnbotris commented Apr 22, 2021 •
edited by mpfau

testing

  • long press of inline image attachment on android or ios will give the user and option to either download or open in another program
  • right click on desktop will give the user the same options

@johnbotris
Copy link
Contributor

johnbotris commented Apr 27, 2021 •
edited

Moving this to 3.83.3 milestone because this release won't include mobile apps

@johnbotris johnbotris modified the milestones: 3.83.0, 3.83.2, 3.83.3, Next release Apr 27, 2021
@jowlo jowlo modified the milestones: Next release, 3.83.8 May 25, 2021
@jowlo jowlo unassigned mpfau May 26, 2021
@mpfau mpfau self-assigned this May 26, 2021
@mpfau mpfau added the state:tested We tested it and are about to release it label May 26, 2021
@mpfau mpfau removed their assignment May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors ios issues that concern the ios client but not all clients state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.84.0
Development

Successfully merging a pull request may close this issue.

Add option to just download inline images on long press tutao/tutanota
3 participants
@mpfau @jowlo @johnbotris