Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back to inbox on device back button press when in folder #2967

Closed
jowlo opened this issue Apr 22, 2021 · 1 comment · Fixed by #2969
Closed

Move back to inbox on device back button press when in folder #2967

jowlo opened this issue Apr 22, 2021 · 1 comment · Fixed by #2969
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.83.7

Comments

@jowlo
Copy link
Contributor

jowlo commented Apr 22, 2021

Bug in mobile app

Describe the bug
When pressing the (device) back button while in a mail folder the app closes instead of going to

To Reproduce

  1. Go to some mail folder
  2. Press device back button
  3. App closes

Expected behavior
The app does not close but changes the view from the folder to the inbox

Additional context
The code path was already there but not triggered correctly.

See this reddit post by a user describing the problem
@jowlo jowlo added bug broken functionality, usability problems, unexpected errors android issues that concern the android client but not all clients labels Apr 22, 2021
jowlo added a commit that referenced this issue Apr 22, 2021
@jowlo
Go to inbox when pressing device back in folder view
09f3364 
fix #2967
jowlo added a commit that referenced this issue Apr 22, 2021
@jowlo
Go to inbox when pressing device back in folder view
c1afc94 
fix #2967
@jowlo jowlo added this to the Next release milestone Apr 22, 2021
@jowlo jowlo mentioned this issue Apr 22, 2021
Merged
@jowlo
Copy link
Contributor Author

jowlo commented Apr 22, 2021 •
edited by johnbotris

Test notes

  • intended:
    1. Open some folder other than inbox on android app
    2. Press device back button
    3. End up in inbox
  • device back button only closes while in inbox, from everywhere else you first get "out of the menus" and end up in inbox

@johnbotris johnbotris modified the milestones: Next release, 3.83.4 Apr 30, 2021
charlag pushed a commit that referenced this issue May 7, 2021
@jowlo @charlag
Go to inbox when pressing device back in folder view
a49e2e1 
fix #2967
@johnbotris johnbotris added the state:tested We tested it and are about to release it label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.83.7
Development

Successfully merging a pull request may close this issue.

Go to inbox when pressing device back in folder view tutao/tutanota
3 participants
@jowlo @johnbotris @Pa7Hub