Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected error dialog when trying to edit a read only event #2973

Closed
bedhub opened this issue Apr 23, 2021 · 1 comment · Fixed by #2982
Closed

Unexpected error dialog when trying to edit a read only event #2973

bedhub opened this issue Apr 23, 2021 · 1 comment · Fixed by #2982
Assignees
@johnbotris
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.83.7

Comments

@bedhub
Copy link
Contributor

bedhub commented Apr 23, 2021

From the calendar event preview dialog it is possible to open the event edit dialog. This might be right to view all the contents of the event but it is also possible to trigger the save action which then leads to an unexpected error message. We should either remove the "Save" action in a read only event or catch the "NotAuthorizedError" and show an appropriate error message.
@bedhub bedhub added the bug broken functionality, usability problems, unexpected errors label Apr 23, 2021
@bedhub bedhub added this to the 3.83.0 milestone Apr 23, 2021
@johnbotris johnbotris modified the milestones: 3.83.0, Next release Apr 23, 2021
@vaf-hub vaf-hub self-assigned this Apr 26, 2021
vaf-hub added a commit that referenced this issue Apr 26, 2021
@vaf-hub
do not allow updates of read-only calendar events, fixes #2973
729d950
@vaf-hub vaf-hub mentioned this issue Apr 26, 2021
Merged
@vaf-hub
Copy link
Contributor

vaf-hub commented Apr 26, 2021 •
edited by johnbotris

Test notes:

  • triggering the save action for calendar events with read-only access is not possible from the CalendarEventEditDialog (the save button is hidden and the Ctrl+S keyboard shortcut is not set)
  • other events can still be saved with a button and the keyboard shortcut

@johnbotris johnbotris modified the milestones: Next release, 3.83.4 Apr 30, 2021
johnbotris pushed a commit that referenced this issue May 7, 2021
@vaf-hub @johnbotris
do not allow updates of read-only calendar events, fixes #2973
16d8122
@johnbotris johnbotris assigned johnbotris and unassigned vaf-hub May 12, 2021
@johnbotris johnbotris added the state:tested We tested it and are about to release it label May 12, 2021
@vitoreiji vitoreiji mentioned this issue Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnbotris johnbotris

Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.83.7
Development

Successfully merging a pull request may close this issue.

do not allow updates of read-only calendar events tutao/tutanota
3 participants
@bedhub @johnbotris @vaf-hub