Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserAlarms are loaded each time #2977

Closed
bedhub opened this issue Apr 26, 2021 · 2 comments · Fixed by #3216
Closed

UserAlarms are loaded each time #2977

bedhub opened this issue Apr 26, 2021 · 2 comments · Fixed by #3216
Assignees
@bedhub
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:tested We tested it and are about to release it
Milestone
3.84.10

Comments

@bedhub
Copy link
Contributor

bedhub commented Apr 26, 2021

When logging in to the desktop client we load the list of UserAlarms and all associated CalendarEvents each time. This should not happen as we keep track of alarms in the native part of the desktop client.

From a first look at the code we should prevent executing scheduleAlarmsLocally() when initializing CalendarModel after login for the desktop client.
@bedhub bedhub added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Apr 26, 2021
@bedhub bedhub added this to the Next release milestone Apr 26, 2021
@johnbotris johnbotris self-assigned this Jun 8, 2021
@johnbotris johnbotris removed their assignment Jun 22, 2021
charlag added a commit that referenced this issue Jun 24, 2021
@charlag
Do not load alarms in web pert of desktop, fix #2977
704bc33
@charlag charlag mentioned this issue Jun 24, 2021
Merged
@charlag charlag self-assigned this Jun 24, 2021
vitoreiji pushed a commit that referenced this issue Jul 1, 2021
@charlag @vitoreiji
Do not load alarms in web pert of desktop, fix #2977
f878678
@vitoreiji
Copy link
Contributor

Test notes

  • Check on debugger that CalendarModelImpl#scheduleAlarmsLocally does not execute loadAlarmEvents on desktop app

@vitoreiji vitoreiji assigned bedhub and unassigned charlag Jul 1, 2021
@charlag
Copy link
Contributor

charlag commented Jul 2, 2021

You could also just check in network inspector that it doesn't download alarms and events

@bedhub bedhub added the state:tested We tested it and are about to release it label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bedhub bedhub

Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.84.10
Development

Successfully merging a pull request may close this issue.

Do not load alarms in web pert of desktop tutao/tutanota
4 participants
@vitoreiji @charlag @bedhub @johnbotris