Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable template popup in mobile #2985

Closed
johnbotris opened this issue Apr 27, 2021 · 1 comment · Fixed by #2995
Closed

Disable template popup in mobile #2985

johnbotris opened this issue Apr 27, 2021 · 1 comment · Fixed by #2995
Assignees
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone

Comments

@johnbotris
Copy link
Contributor

johnbotris commented Apr 27, 2021

We disable the template popup in mobile because we view it's primary use case as being for usage on desktop, answering many emails at a time. If this changes then we can revisit the popup, but it would need a makeover

@johnbotris johnbotris added the bug broken functionality, usability problems, unexpected errors label Apr 27, 2021
johnbotris added a commit that referenced this issue Apr 27, 2021
we still need to make the popup layout suit mobile better
@johnbotris johnbotris modified the milestones: 3.83.3, Next release Apr 28, 2021
@johnbotris johnbotris modified the milestones: Next release, 3.83.4 May 7, 2021
johnbotris added a commit that referenced this issue May 7, 2021
we still need to make the popup layout suit mobile better
@johnbotris johnbotris linked a pull request May 7, 2021 that will close this issue
@johnbotris johnbotris changed the title Fix template popup in mobile Disable template popup in mobile May 7, 2021
@johnbotris
Copy link
Contributor Author

johnbotris commented May 7, 2021

Testing

  • From any desktop device in the browser or the electron client, the template popup is available in the mail editor
  • From any mobile device, in the browser or the app, the template popup is not available in the mail editor

johnbotris added a commit that referenced this issue May 7, 2021
* dont close template popup on window resize in mobile, #2985

we still need to make the popup layout suit mobile better

* Disable template popup in mobile, #2985

* disable template popup in mobile browsers
@charlag charlag self-assigned this May 12, 2021
@charlag charlag added the state:tested We tested it and are about to release it label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants