Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laggy animation when opening email on mobile #3099

Closed
charlag opened this issue May 25, 2021 · 1 comment · Fixed by #3092
Closed

Laggy animation when opening email on mobile #3099

charlag opened this issue May 25, 2021 · 1 comment · Fixed by #3092
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.84.0

Comments

@charlag
Copy link
Contributor

charlag commented May 25, 2021

No description provided.

@charlag charlag added the bug broken functionality, usability problems, unexpected errors label May 25, 2021
@charlag charlag added this to the 3.83.8 milestone May 25, 2021
charlag added a commit that referenced this issue May 25, 2021
@charlag
Defer rendering mail body until viewSlider animation is over, fix #3099
220b24f 
This avoids big frame losses by separating re-layouts. ViewSlider
animations trigger layout and showing/scaling mail body does too.
@charlag charlag linked a pull request May 25, 2021 that will close this issue
Defer rendering mail body until viewSlider animation is over. #3092
Merged
@charlag
Copy link
Contributor Author

charlag commented May 25, 2021 •
edited by johnbotris

Test notes:

  • Opening mails from the list on mobile
  • Deleteing a mail and having another one selected on mobile
  • Opening mails from the list on desktop
  • Deleteing a mail and having another one selected on desktop
  • Multiple emails selected
  • Selecting mail from search

charlag added a commit that referenced this issue May 26, 2021
@charlag
Defer rendering mail body until viewSlider animation is over, fix #3099
24f7ffd 
This avoids big frame losses by separating re-layouts. ViewSlider
animations trigger layout and showing/scaling mail body does too.
mpfau pushed a commit that referenced this issue May 26, 2021
@charlag @mpfau
Defer rendering mail body until viewSlider animation is over, fix #3099
c03d671 
This avoids big frame losses by separating re-layouts. ViewSlider
animations trigger layout and showing/scaling mail body does too.
@johnbotris johnbotris self-assigned this May 26, 2021
@johnbotris johnbotris added the state:tested We tested it and are about to release it label May 26, 2021
@johnbotris johnbotris removed their assignment May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.84.0
Development

Successfully merging a pull request may close this issue.

Defer rendering mail body until viewSlider animation is over. tutao/tutanota
2 participants
@charlag @johnbotris