Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Desktop Client can't register as default mail app #3155

Closed
ganthern opened this issue Jun 3, 2021 · 1 comment
Closed

[windows] Desktop Client can't register as default mail app #3155

ganthern opened this issue Jun 3, 2021 · 1 comment
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:tested We tested it and are about to release it
Milestone
3.84.10

Comments

@ganthern
Copy link
Contributor

ganthern commented Jun 3, 2021 •
edited

When trying to register with Settings -> Desktop -> Default Email Handler
the app will ask for registry access and show that it's registered, but it will not
show as an option in the Windows Default Apps Settings.

After restarting the app, the menu option will show "Not Registered" again.

Some possible reasons:

  • elevate.exe doesn't work anymore to get admin permissions
  • we're setting the wrong keys (but then the option should stay on "registered")
  • the node winreg package is doing something wrong
  • the recursive call of the client with the -r or -u switches fails somehow
@ganthern ganthern added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Jun 3, 2021
@ganthern ganthern self-assigned this Jun 3, 2021
@bedhub bedhub added this to the 3.84.5 milestone Jun 3, 2021
@johnbotris johnbotris removed this from the 3.84.5 milestone Jun 15, 2021
@bedhub bedhub added this to the Next release milestone Jun 23, 2021
@bedhub
Copy link
Contributor

bedhub commented Jun 24, 2021 •
edited

Is this issue somehow connected or can we mark it as duplicate? #3075

ganthern added a commit that referenced this issue Jun 29, 2021
@ganthern
[desktop] seed prng when loading it, close #3155
c25e6e9 
registering / unregistering as mailto handler on windows
calls tutanota recursively with a command line argument.
this nested instance needs random bytes very early in the
run and the used prng to throws if it's not seeded.

this caused the registry write to fail silently,
leading to #3155

this commit seeds the prng with node.crypto.randomBytes
after importing it and adds some logging so the nested
instances leave info as to what happened in the logs should
they error out.
@ganthern ganthern mentioned this issue Jun 29, 2021
Closed
ganthern added a commit that referenced this issue Jun 29, 2021
@ganthern
[desktop] seed prng when loading it, close #3155
682318e 
registering / unregistering as mailto handler on windows
calls tutanota recursively with a command line argument.
this nested instance needs random bytes very early in the
run and the used prng throws if it's not seeded.

this caused the registry write to fail silently,
leading to #3155

this commit seeds the prng with node.crypto.randomBytes
after importing it and adds some logging so the nested
instances leave info as to what happened in the logs should
they error out.
@ganthern ganthern linked a pull request Jun 29, 2021 that will close this issue
[desktop] seed prng when loading it, close #3155 #3223
Closed
@ganthern ganthern mentioned this issue Jun 29, 2021
Closed
@charlag charlag self-assigned this Jul 2, 2021
@charlag charlag added the state:tested We tested it and are about to release it label Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.84.10
Development

Successfully merging a pull request may close this issue.

[desktop] seed prng when loading it, close #3155 tutao/tutanota
4 participants
@charlag @bedhub @johnbotris @ganthern