Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1-3 keys for switching between calendar views do not work #3225

Closed
charlag opened this issue Jun 29, 2021 · 2 comments
Closed

1-3 keys for switching between calendar views do not work #3225

charlag opened this issue Jun 29, 2021 · 2 comments
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.84.11

Comments

@charlag
Copy link
Contributor

charlag commented Jun 29, 2021

They are listed in the code but they are not in F1 help and do not work.
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Jun 29, 2021
@ganthern ganthern added this to the Next release milestone Jul 1, 2021
@ganthern
Copy link
Contributor

ganthern commented Jul 1, 2021

  • MailView is registering Shortcuts depending on the customer object which means it needs to await before calling the KeyManager in oncreate/onremove.
  • This places the unregisterShortcuts call behind CalendarViews' registerShortcuts call
  • both of them use 1-3, therefore MailView's unregister call will remove the Shortcuts the CalendarView just added.

ganthern added a commit that referenced this issue Jul 1, 2021
@ganthern
buffer async shortcut operations, close #3225
7a83ede
@ganthern ganthern linked a pull request Jul 1, 2021 that will close this issue
remove old Component type, separate f1 help gui from keymanager #3235
Merged
ganthern added a commit that referenced this issue Jul 1, 2021
@ganthern
buffer async shortcut operations, close #3225
246e22d
ganthern added a commit that referenced this issue Jul 6, 2021
@ganthern
buffer async shortcut operations, close #3225
239adb9
@bedhub bedhub modified the milestones: Next release, 3.84.11 Jul 7, 2021
@vitoreiji
Copy link
Contributor

Fixed by 99e0112

@vitoreiji vitoreiji added the state:tested We tested it and are about to release it label Jul 7, 2021
@ganthern ganthern mentioned this issue Jul 8, 2021
Merged
@ganthern ganthern removed a link to a pull request Jul 8, 2021
remove old Component type, separate f1 help gui from keymanager #3235
Merged
ganthern added a commit that referenced this issue Aug 5, 2021
@ganthern
prevent the help dialog from showing the support dropdown shortcuts, c…
81a32ee 
…lose #3225
ganthern added a commit that referenced this issue Aug 5, 2021
@ganthern
prevent the help dialog from showing the support dropdown shortcuts
efd87d8 
close #3225
@ganthern ganthern mentioned this issue Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.84.11
Development

No branches or pull requests
4 participants
@vitoreiji @charlag @bedhub @ganthern