Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confidential button in new email tooltip text is always "confidential" #3254

Closed
6 tasks done
armhub opened this issue Jul 7, 2021 · 0 comments · Fixed by #4519
Closed
6 tasks done

Confidential button in new email tooltip text is always "confidential" #3254

armhub opened this issue Jul 7, 2021 · 0 comments · Fixed by #4519
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Milestone
3.100.2

Comments

@armhub
Copy link
Contributor

armhub commented Jul 7, 2021 •
edited by charlag

Expected: Depending on the state it should either be "Confidential" or "Not confidential".

Testing notes

  • Open the dialog for a new mail
  • Put an external recipient
  • See the "confidential button" (lock icon) appear
  • Hover over it when the mail is confidential and ensure the tooltip says "Confidential"
  • Click the button to make the mail not confidential
  • Hover over it when the mail is not confidential and ensure the tooltip says "Not confidential"
@armhub armhub added the bug broken functionality, usability problems, unexpected errors label Jul 7, 2021
@ganthern ganthern added the ui visual glitches, missing buttons, wrong text... label Aug 15, 2022
@ghost ghost self-assigned this Aug 19, 2022
ghost pushed a commit that referenced this issue Aug 19, 2022
@kitsugo
Wrong label on confidential button in the mail editor.
3a9ea54 
Added condition to check what label should be used.

fixes #3254
@ghost ghost mentioned this issue Aug 19, 2022
Merged
@charlag charlag added the state:done meets our definition of done label Sep 15, 2022
@bedhub bedhub added this to the 3.100.x milestone Sep 19, 2022
@charlag charlag unassigned ghost Sep 20, 2022
@charlag charlag modified the milestones: 3.100.x, 3.100.1 Sep 20, 2022
charlag pushed a commit that referenced this issue Sep 20, 2022
@kitsugo @charlag
Wrong label on confidential button in the mail editor.
a0619a8 
Added condition to check what label should be used.

fixes #3254
@charlag charlag self-assigned this Sep 20, 2022
@charlag charlag added the state:tested We tested it and are about to release it label Sep 20, 2022
@charlag charlag removed their assignment Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Projects
None yet
Milestone
3.100.2
Development

Successfully merging a pull request may close this issue.

Wrong label on confidential button in the mail editor tutao/tutanota
4 participants
@charlag @armhub @bedhub @ganthern