Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three digit colors in whitelabel theme causes crash/error in apps #3303

Closed
7 tasks done
johnbotris opened this issue Jul 19, 2021 · 2 comments · Fixed by #3307
Closed
7 tasks done

Three digit colors in whitelabel theme causes crash/error in apps #3303

johnbotris opened this issue Jul 19, 2021 · 2 comments · Fixed by #3307
Labels
android issues that concern the android client but not all clients desktop Desktop client related issues dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) ios issues that concern the ios client but not all clients state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.85.6

Comments

@johnbotris
Copy link
Contributor

johnbotris commented Jul 19, 2021 •
edited by bedhub

We didn't release 3.83.5 for iOS because there were some bigger issues that need fixing, relating to #2804. We should fix them and then make a 3.85.3 iOS release, or do it with the next release

Update: This is due to 3 digit hex color codes not being handled in the native part, and also happens in android

testing

Test in

  • desktop
  • ios
  • android
  • in whitelabel color config, set header_bg and content_bg to three digit hex codes
@johnbotris johnbotris added dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) ios issues that concern the ios client but not all clients labels Jul 19, 2021
@johnbotris johnbotris added this to the 3.85.x milestone Jul 19, 2021
@johnbotris johnbotris added the android issues that concern the android client but not all clients label Jul 21, 2021
bedhub added a commit that referenced this issue Jul 21, 2021
@bedhub
[ios] handle 3 digit color codes when detecting background lightness
f1e9206 
also refactor to reuse the color parsing implementation we already had

#3303
johnbotris added a commit that referenced this issue Jul 21, 2021
@johnbotris
[android] handle three digit hex color codes
d7b7940 
and a slight refactor

#3303
@johnbotris johnbotris added the desktop Desktop client related issues label Jul 21, 2021
johnbotris added a commit that referenced this issue Jul 21, 2021
@johnbotris
[desktop] handle three digit hex color codes
53481e7 
#3303
@johnbotris johnbotris mentioned this issue Jul 21, 2021
Merged
@vitoreiji vitoreiji added the state:done meets our definition of done label Jul 21, 2021
vitoreiji pushed a commit that referenced this issue Jul 22, 2021
@bedhub @vitoreiji
[ios] handle 3 digit color codes when detecting background lightness
a86f8e4 
also refactor to reuse the color parsing implementation we already had

#3303
vitoreiji pushed a commit that referenced this issue Jul 22, 2021
@johnbotris @vitoreiji
[android] handle three digit hex color codes
ee2aa4c 
and a slight refactor

#3303
vitoreiji pushed a commit that referenced this issue Jul 22, 2021
@johnbotris @vitoreiji
[desktop] handle three digit hex color codes
f1356c1 
#3303
@bedhub
Copy link
Contributor

bedhub commented Jul 22, 2021 •
edited

App do not crash anymore but ios has this issue #3312. We should release web, desktop and android version and release iOS later

@bedhub bedhub reopened this Jul 22, 2021
@vitoreiji
Copy link
Contributor

status bar on android does not adapt to the color header_bg or content_bg

It does adapt to header_bg for me on Android 7.1.2:

adapted_statusbar_android

@bedhub bedhub changed the title iOS app doesn't start Three digit colors in customer theme causes crash/error in apps Jul 23, 2021
@bedhub bedhub changed the title Three digit colors in customer theme causes crash/error in apps Three digit colors in whitelabel theme causes crash/error in apps Jul 23, 2021
@bedhub bedhub closed this as completed Jul 23, 2021
@bedhub bedhub added the state:tested We tested it and are about to release it label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android issues that concern the android client but not all clients desktop Desktop client related issues dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) ios issues that concern the ios client but not all clients state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.85.6
Development

Successfully merging a pull request may close this issue.

Handle 3 digit color codes in custom theme for native tutao/tutanota
3 participants
@vitoreiji @bedhub @johnbotris