Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save mail as draft when closing unless changes have been made #3580

Closed
7 tasks done
Pa7Hub opened this issue Oct 20, 2021 · 4 comments · Fixed by #4115
Closed
7 tasks done

Don't save mail as draft when closing unless changes have been made #3580

Pa7Hub opened this issue Oct 20, 2021 · 4 comments · Fixed by #4115
Assignees
Labels
small improvement A small improvement which can hopefully be implemented within a short time frame. state:tested We tested it and are about to release it
Milestone

Comments

@Pa7Hub
Copy link
Contributor

Pa7Hub commented Oct 20, 2021

With the new minimization of mails we also save a draft upon closing the editor. This helps when finishing a mail and saving changes that have been made, however can get annoying when every close triggers a draft save.

It would be better and more convenient that we only save a draft if changes have been made to the mail.

AC:

  • If I do not change the body of the mail, pressing close should not trigger a draft save. Only when something has been changed (such as recipients, title, etc.) should we trigger a draft save.

Discussed with @johnbotris @Pa7Hub , should be discussed again with @bedhub

Test notes

  • Create a new email without writing anything in it.
  • Close the email. It should not save a draft.
  • Create another new email, but this time change something in it (upload an attachment, etc.)
  • Close the email. It should save a draft.
  • the above works with forwarding and replies
  • when a draft is saved with a recipient from the contacts, then opened (without changing it) and the contact gets edited (loses the mail address), the draft is saved on closing it.
  • notification mails for calendar event participants still work
@Pa7Hub Pa7Hub added bug broken functionality, usability problems, unexpected errors small improvement A small improvement which can hopefully be implemented within a short time frame. and removed bug broken functionality, usability problems, unexpected errors labels Oct 20, 2021
@vachan-maker
Copy link

Yep, this improvement would be nice.

@charlag
Copy link
Contributor

charlag commented Oct 22, 2021

We decided before with @bedhub that it will be more consistent to always save as there are some cases where you might expect it e.g. when it is a reply and you want to come back to it

@LewisMichaelHarold
Copy link

I have an android mobile device and my drafts are not saved when closing the app?

@Jlll1
Copy link
Contributor

Jlll1 commented May 14, 2022

Maybe in case of empty messages we could just prompt the user if he wants to save it as draft? My Messaging app does that for empty messages.

@ganthern ganthern added this to the 3.98.13 milestone Jul 21, 2022
ganthern added a commit that referenced this issue Jul 21, 2022
close #3580

Co-authored-by: paw-hub <paw@tutao.de>
ganthern added a commit that referenced this issue Jul 21, 2022
close #3580

Co-authored-by: paw-hub <paw@tutao.de>
@charlag charlag self-assigned this Jul 22, 2022
@ganthern ganthern assigned charlag and unassigned charlag Jul 25, 2022
@johnbotris johnbotris added the state:tested We tested it and are about to release it label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small improvement A small improvement which can hopefully be implemented within a short time frame. state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants