Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailto integration on Windows: local installation for non-admin user #3752

Closed
charlag opened this issue Dec 21, 2021 · 1 comment · Fixed by #3756
Closed

Mailto integration on Windows: local installation for non-admin user #3752

charlag opened this issue Dec 21, 2021 · 1 comment · Fixed by #3756
Labels
desktop Desktop client related issues dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.91.2

Comments

@charlag
Copy link
Contributor

charlag commented Dec 21, 2021

see #3574

To Reproduce
Steps to reproduce the behavior:

  1. As non-admin user, install the app locally
  2. Try to register app as mailto handler on the same user (Settings -> Desktop)
  3. See that Tutanota is not in the list of available apps

Desktop (please complete the following information):
Windows 10
3.91.0

Additional context
During mailto registration the app still tries to elevate permissions. This is probably wrong as we should be writing to the local registry and should do so with current user context.
@charlag charlag added dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) desktop Desktop client related issues labels Dec 21, 2021
@charlag charlag added this to the 3.91.0 milestone Dec 21, 2021
@charlag
Copy link
Contributor Author

charlag commented Dec 22, 2021

I checked code path and we indeed always try to elevate. I think it should not be necessary for local install.

charlag added a commit that referenced this issue Dec 22, 2021
@charlag
Fix registering mailto on Windows as non-admin user, fix #3752
a9f88d7
@charlag charlag mentioned this issue Dec 22, 2021
Merged
ganthern added a commit that referenced this issue Jan 11, 2022
@ganthern
[desktop] Fix registering mailto on Windows as non-admin user, fix #3752
a0e900d
ganthern added a commit that referenced this issue Jan 11, 2022
@ganthern
[desktop] Fix registering mailto on Windows as non-admin user, fix #3752
c93a090
@charlag charlag added the state:done meets our definition of done label Jan 11, 2022
charlag pushed a commit that referenced this issue Jan 12, 2022
@ganthern @charlag
[desktop] Fix registering mailto on Windows as non-admin user, fix #3752
3200350
charlag pushed a commit that referenced this issue Jan 12, 2022
@ganthern @charlag
[desktop] Fix registering mailto on Windows as non-admin user, fix #3752
b40818c
@charlag charlag self-assigned this Jan 13, 2022
@charlag charlag mentioned this issue Jan 13, 2022
Open
@charlag charlag added the state:tested We tested it and are about to release it label Jan 13, 2022
@charlag charlag mentioned this issue Jan 13, 2022
Closed
@charlag charlag removed their assignment Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
desktop Desktop client related issues dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.91.2
Development

Successfully merging a pull request may close this issue.

[desktop/win32] Fix registering mailto on Windows as non-admin user tutao/tutanota
1 participant
@charlag