Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resetting second factor from 2FA prompt does not cancel login properly #4008

Closed
2 tasks done
charlag opened this issue Apr 5, 2022 · 2 comments · Fixed by #4416
Closed
2 tasks done

Resetting second factor from 2FA prompt does not cancel login properly #4008

charlag opened this issue Apr 5, 2022 · 2 comments · Fixed by #4416
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.98.17

Comments

@charlag
Copy link
Contributor

charlag commented Apr 5, 2022 •
edited

  1. Have second factor for an account
  2. Try to log in with that account, see 2FA prompt
  3. Click on "lost account access link"
  4. See that new dialog is opened, close that dialog
  5. See that the progress is still ongoing. 2FA dialog was closed but the login was not cancelled.

Test Notes:

  • reproduction doesn't work anymore with hardware key
  • also not with OTP
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Apr 5, 2022
@ganthern
Copy link
Contributor

ganthern commented Jul 25, 2022 •
edited

Similar thing happens in the desktop client if you replace steps 3 and 4 with "click cancel in the 2FA prompt", but in this case the login gets eventually cancelled after the network request times out.

@ganthern ganthern mentioned this issue Jul 25, 2022
Open
@ganthern ganthern added the state:done meets our definition of done label Jul 28, 2022
@ganthern ganthern self-assigned this Jul 28, 2022
@ganthern ganthern added this to the 3.98.16 milestone Jul 29, 2022
@ganthern ganthern removed their assignment Jul 29, 2022
ganthern added a commit that referenced this issue Jul 29, 2022
@ganthern
properly cancel createSession when recovery process is started
89eae17 
recoverLogin in the SecondFactorAuthDialog would only close the dialog
but not cancel the login process, which would then get stuck if the
recovery process was canceled.

fix #4008
ganthern added a commit that referenced this issue Jul 29, 2022
@ganthern
[desktop] fix second factor long poll blocking all ProtocolProxy sockets
b9073d6 
fix #4008
@ganthern ganthern mentioned this issue Jul 29, 2022
Merged
@charlag charlag self-assigned this Jul 29, 2022
@charlag charlag added the state:tested We tested it and are about to release it label Jul 29, 2022
@charlag
Copy link
Contributor Author

charlag commented Jul 29, 2022

There's a slight visual glitch when switching between the dialogs (we probably should close one before opening another) but otherwise it's okay

@charlag charlag removed their assignment Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.98.17
Development

Successfully merging a pull request may close this issue.

2FA fixes tutao/tutanota
2 participants
@charlag @ganthern