Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some editor dialogs get closed if a connection error occurs #4025

Closed
5 tasks done
sarashub opened this issue Apr 6, 2022 · 0 comments · Fixed by #4041
Closed
5 tasks done

Some editor dialogs get closed if a connection error occurs #4025

sarashub opened this issue Apr 6, 2022 · 0 comments · Fixed by #4041
Assignees
@johnbotris
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.96.1

Comments

@sarashub
Copy link
Contributor

sarashub commented Apr 6, 2022 •
edited by johnbotris

This is the case e. g. when creating new folders or creating rules.
Instead editor dialogs should always stay open if a connection error occurs.

Testnotes

  • Open dialog to create a spam rule, go offline, click okay, observe that dialog does not close
  • Open dialog to edit a spam rule, go offline, click okay, observe that dialog does not close
  • Open dialog to create an inbox rule, go offline, click okay, observe that dialog does not close
  • Open dialog to edit an inbox rule, go offline, click okay, observe that dialog does not close
  • Open dialogs to edit a string (e.g. create or edit calendar) , go offline, click okay, observe that dialog does not close
@sarashub sarashub added the bug broken functionality, usability problems, unexpected errors label Apr 6, 2022
@sarashub sarashub self-assigned this Apr 12, 2022
sarashub added a commit that referenced this issue Apr 13, 2022
@sarashub
Do not close editor dialogs if a ConnectionError occurs, fix #4025
3172ce9
sarashub added a commit that referenced this issue Apr 13, 2022
@sarashub
Do not close editor dialogs if a ConnectionError occurs, fix #4025
5102092
@sarashub sarashub mentioned this issue Apr 13, 2022
Merged
sarashub added a commit that referenced this issue Apr 14, 2022
@sarashub
Do not close editor dialogs if a ConnectionError occurs, fix #4025
de43eae 
* In the faulty cases the dialog was closed without waiting for the entered data to be processed. Now these dialogs only close after the okayAction succeeds or fails with an error that is not a ConnectionError.
@ganthern ganthern added the state:done meets our definition of done label Apr 14, 2022
charlag pushed a commit that referenced this issue Apr 22, 2022
@sarashub @charlag
Do not close editor dialogs if a ConnectionError occurs, fix #4025
3a7c9b8 
* In the faulty cases the dialog was closed without waiting for the entered data to be processed. Now these dialogs only close after the okayAction succeeds or fails with an error that is not a ConnectionError.
@charlag charlag added this to the 3.96.0 milestone Apr 28, 2022
@johnbotris johnbotris self-assigned this Apr 29, 2022
@johnbotris johnbotris added the state:tested We tested it and are about to release it label Apr 29, 2022
This was referenced May 17, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnbotris johnbotris

Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.96.1
Development

Successfully merging a pull request may close this issue.

Do not close editor dialogs if a ConnectionError occurs, fix #4025 tutao/tutanota
4 participants
@charlag @johnbotris @ganthern @sarashub