Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request errors are not handled #4387

Closed
charlag opened this issue Jul 20, 2022 · 0 comments · Fixed by #4415
Closed

Request errors are not handled #4387

charlag opened this issue Jul 20, 2022 · 0 comments · Fixed by #4415
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:not-testable "tested" for blind fixes or old code removal with no expected regressions
Milestone
3.98.17

Comments

@charlag
Copy link
Contributor

charlag commented Jul 20, 2022 

java.lang.IllegalStateException: 
  at de.tutao.tutanota.RemoteBridge.handleMessageFromWeb (RemoteBridge.kt:106)
  at de.tutao.tutanota.RemoteBridge$initMessageChannel$1$onMessage$1.invokeSuspend (RemoteBridge.kt:59)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:106)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.kt:571)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:750)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:678)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:665)

this happens in

tutanota/app-android/app/src/main/java/de/tutao/tutanota/RemoteBridge.kt

Line 106 in 10a26bf

else -> error("unknown message type")

it should handle requestError message type
@charlag charlag added bug broken functionality, usability problems, unexpected errors android issues that concern the android client but not all clients labels Jul 20, 2022
@ganthern ganthern assigned ganthern and unassigned ganthern Jul 25, 2022
@ganthern ganthern added the state:not-testable "tested" for blind fixes or old code removal with no expected regressions label Jul 28, 2022
ganthern added a commit that referenced this issue Jul 28, 2022
@ganthern @charlag
[android] handle error response from native-to-web requests
bd7cf16 
close #4387

Co-authored-by: ivk <ivk@tutao.de>
@ganthern ganthern mentioned this issue Jul 28, 2022
Merged
@ganthern ganthern added the state:done meets our definition of done label Jul 28, 2022
@ganthern ganthern added this to the 3.98.16 milestone Jul 29, 2022
@ganthern ganthern removed their assignment Jul 29, 2022
ganthern added a commit that referenced this issue Jul 29, 2022
@ganthern @charlag
[android] handle error response from native-to-web requests
53d0307 
close #4387

Co-authored-by: ivk <ivk@tutao.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:not-testable "tested" for blind fixes or old code removal with no expected regressions
Projects
None yet
Milestone
3.98.17
Development

Successfully merging a pull request may close this issue.

[android] handle error response from native-to-web requests tutao/tutanota
2 participants
@charlag @ganthern