Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show minimized draft even for unchanged drafts #4396

Closed
ganthern opened this issue Jul 22, 2022 · 1 comment · Fixed by #4865
Closed

show minimized draft even for unchanged drafts #4396

ganthern opened this issue Jul 22, 2022 · 1 comment · Fixed by #4865
Labels
improvement nice-to-haves that are not impeding usage of any features state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@ganthern
Copy link
Contributor

ganthern commented Jul 22, 2022

As a user i expect that once my draft has been minimized that it will be always minimized again when opening it again so that i can always continue writing the draft.

AC:

  • Opening a minimized draft and close it should minimize even no changes were made.
  • Closing the mail editor without existing draft and without changes should not minimize.

Notes
We introduced this behavior because we do not want to store empty drafts, see:
#4105

We like to keep this behavior but once the draft has been saved the editor should be minimized. There are multiple solution how to deal with this but we decided for the solution that "If there's an existing draft, always minimize it when closing"

See refinement discussion in the wiki for more details.

@ganthern ganthern added improvement nice-to-haves that are not impeding usage of any features idea notes down not immediately solvable things that don't have general buy-in yet labels Jul 22, 2022
@bedhub bedhub removed the idea notes down not immediately solvable things that don't have general buy-in yet label Dec 12, 2022
@wrdhub wrdhub self-assigned this Dec 19, 2022
wrdhub added a commit that referenced this issue Dec 19, 2022
@wrdhub
Copy link
Contributor

wrdhub commented Dec 19, 2022

Test Notes:

  • Closing Empty Email will not result in saved draft or minimized draft
  • Editing mail from Draft folder will result in minimized draft when closed
  • Editing from minimized draft will result in minimized draft when closed

@charlag charlag added the state:done meets our definition of done label Dec 19, 2022
@ganthern ganthern added this to the 3.106.0 milestone Dec 19, 2022
ganthern pushed a commit that referenced this issue Dec 19, 2022
@ganthern ganthern assigned ganthern and unassigned wrdhub and ganthern Dec 20, 2022
@ganthern ganthern added the state:tested We tested it and are about to release it label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement nice-to-haves that are not impeding usage of any features state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants