Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Move" shortcut [V] doesn't work in search view #4510

Closed
6 of 8 tasks
ganthern opened this issue Aug 17, 2022 · 1 comment · Fixed by #5057
Closed
6 of 8 tasks

"Move" shortcut [V] doesn't work in search view #4510

ganthern opened this issue Aug 17, 2022 · 1 comment · Fixed by #5057
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.109.2

Comments

@ganthern
Copy link
Contributor

ganthern commented Aug 17, 2022 •
edited

When you select mail in the mail view, you can press "V" to open the folder dropdown to move selected mail.

This currently doesn't work in the Search View (Search Bar -> Enter). The shortcut is also not showing up in the F1 help menu.

Test Notes

In the web app:

on mobile:

  • the v shortcut works now
  • you can still move mails with the dropdown
  • all functions in the multi-mail viewer in the mail view work
  • all functions in the multi-mail viewer in the search view work see above
@ganthern ganthern added the bug broken functionality, usability problems, unexpected errors label Aug 17, 2022
@ganthern ganthern mentioned this issue Jan 19, 2023
Closed
3 tasks
@nokhub nokhub self-assigned this Jan 20, 2023
nokhub added a commit that referenced this issue Jan 27, 2023
@nokhub
Add move shortcut to the SearchView
c4aee32 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
@nokhub nokhub mentioned this issue Jan 27, 2023
Merged
nokhub added a commit that referenced this issue Jan 30, 2023
@nokhub
Add move shortcut to the SearchView
f6aec47 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
nokhub added a commit that referenced this issue Jan 30, 2023
@nokhub
Add move shortcut to the SearchView
fae3f8d 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
nokhub added a commit that referenced this issue Jan 30, 2023
@nokhub
Add move shortcut to the SearchView
72a1b53 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
nokhub added a commit that referenced this issue Jan 31, 2023
@nokhub
Add move shortcut to the SearchView
6ba388a 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
@charlag charlag added the state:done meets our definition of done label Feb 1, 2023
@charlag charlag added this to the 3.109.2 milestone Feb 9, 2023
ganthern pushed a commit that referenced this issue Feb 10, 2023
@nokhub @ganthern
Add move shortcut to the SearchView
ae55bb3 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
ganthern pushed a commit that referenced this issue Feb 10, 2023
@nokhub @ganthern
Add move shortcut to the SearchView
e5f804c 
Before few places in the code used different and slightly invalid
checks for moving mails, e.g. single and multiple mail selections were
different, or the check for the same mailbox was done but the check for
the correct folder was omitted.

This change unifies the implementations to always use the same logic.

fix #4510
@ganthern ganthern removed the state:done meets our definition of done label Feb 10, 2023
@ganthern ganthern self-assigned this Feb 13, 2023
@ganthern
Copy link
Contributor Author

#5126

@ganthern ganthern added the state:tested We tested it and are about to release it label Feb 13, 2023
@ganthern ganthern removed their assignment Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.109.2
Development

Successfully merging a pull request may close this issue.

Fix shortcuts in SearchView tutao/tutanota
3 participants
@charlag @ganthern @nokhub