Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log is not available for free accounts #4539

Closed
8 tasks done
kib42 opened this issue Aug 25, 2022 · 1 comment · Fixed by #4552
Closed
8 tasks done

Audit log is not available for free accounts #4539

kib42 opened this issue Aug 25, 2022 · 1 comment · Fixed by #4552
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@kib42
Copy link

kib42 commented Aug 25, 2022

The Audit Log is not shown for free account regardless of the client.

Steps to reproduce

  1. Log in to a free account
  2. Go to Settings > Global settings
  3. See Audit log missing

Test notes

  • Log into a free account
  • Go to global settings
  • Check that there is an audit log
  • Change the user's password
  • Go back and verify that the audit log reflects this change
  • the global settings for a the account don't show the "enforce password change" setting

Regressions

  • the global settings for a premium account (global admin) show a functional audit log
  • the global settings for a premium account (global admin) show the "enforce password change" setting
@kib42 kib42 added the bug broken functionality, usability problems, unexpected errors label Aug 25, 2022
@paw-hub paw-hub self-assigned this Sep 2, 2022
paw-hub added a commit that referenced this issue Sep 2, 2022
There isn't really any reason the client can't show this for free users
as it appears to be fully functional on free accounts and may be useful
to note when a password was changed for example.

Fixes #4539
@charlag charlag modified the milestone: 3.100.1 Sep 15, 2022
@armhub
Copy link
Contributor

armhub commented Sep 27, 2022

If I am not mistaken this code change also displays the password reset option for Free accounts. I would not show it since it only makes sense for accounts with multiple users.

@armhub armhub assigned armhub and unassigned paw-hub Sep 27, 2022
@ganthern ganthern added the state:done meets our definition of done label Sep 30, 2022
@ganthern ganthern added this to the 3.101.0 milestone Sep 30, 2022
ganthern pushed a commit that referenced this issue Sep 30, 2022
There isn't really any reason the client can't show this for free users
as it appears to be fully functional on free accounts and may be useful
to note when a password was changed for example.

Fixes #4539
@nokhub nokhub self-assigned this Oct 5, 2022
@nokhub nokhub added the state:tested We tested it and are about to release it label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants