Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expired session handling produces an error on no-offline platforms #4571

Closed
charlag opened this issue Sep 12, 2022 · 0 comments · Fixed by #4572
Closed

Expired session handling produces an error on no-offline platforms #4571

charlag opened this issue Sep 12, 2022 · 0 comments · Fixed by #4572
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.100.2

Comments

@charlag
Copy link
Contributor

charlag commented Sep 12, 2022 •
edited 

Client: Browser
Tutanota version: 3.100.0
User agent:
Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0
TypeError
Error message: br.sqlCipherFacade is undefined
Stacktrace:
action@https://mail.tutanota.com/main-3d3f9930.js:1:98048

this happens here:

tutanota/src/misc/ErrorHandlerImpl.ts

Line 199 in 4b767be

await locator.sqlCipherFacade.closeDb()

sqlCipherFacade is not there for web and iOS.

To reproduce you need to open the app, wait for the session timeout (by default one day, can changed locally by SESSION_TIMEOUT_IN_SECONDS) and then try to load something. You will get a password prompt and after submitting the password it will produce an error.
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Sep 12, 2022
charlag added a commit that referenced this issue Sep 12, 2022
@charlag
Fix recovering expired sessions when there's no offline
15dfd01 
fix #4571
@charlag charlag mentioned this issue Sep 12, 2022
Merged
@bedhub bedhub assigned bedhub and unassigned armhub Sep 14, 2022
@charlag charlag added the state:done meets our definition of done label Sep 15, 2022
@bedhub bedhub added this to the 3.100.x milestone Sep 19, 2022
@charlag charlag modified the milestones: 3.100.x, 3.100.1 Sep 20, 2022
charlag added a commit that referenced this issue Sep 20, 2022
@charlag
Fix recovering expired sessions when there's no offline
93cc68e 
fix #4571
@kib42 kib42 self-assigned this Sep 20, 2022
@kib42 kib42 added the state:tested We tested it and are about to release it label Sep 20, 2022
@kib42 kib42 removed their assignment Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.100.2
Development

Successfully merging a pull request may close this issue.

Fix recovering expired sessions when there's no offline tutao/tutanota
4 participants
@charlag @armhub @bedhub @kib42