Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update electron to 21.1.1 #4623

Closed
3 tasks done
ganthern opened this issue Sep 30, 2022 · 0 comments · Fixed by #4672
Closed
3 tasks done

update electron to 21.1.1 #4623

ganthern opened this issue Sep 30, 2022 · 0 comments · Fixed by #4672
Labels
desktop Desktop client related issues maintenance dependency updates, key renewals, code cleanup state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.103.3

Comments

@ganthern
Copy link
Contributor

ganthern commented Sep 30, 2022 •
edited by charlag

Test Notes

  • smoke test mac
  • smoke test windows
  • smoke test linux
@ganthern ganthern added desktop Desktop client related issues maintenance dependency updates, key renewals, code cleanup labels Sep 30, 2022
@ganthern ganthern added this to the 3.101.0 milestone Sep 30, 2022
ganthern added a commit that referenced this issue Sep 30, 2022
@ganthern
[maintenance] update electron to 20.3.0
5c5703e 
also update electron-packager, electron-updater and electron-builder

this is a major version upgrade. relevant breaking change:
electronjs.org/docs/latest/breaking-changes#removed-skiptaskbar-on-linux

we do use it to hide the webDialog from the task bar during 2nd factor
login, but if it's removed we can live with it.

close #4623
@ganthern ganthern mentioned this issue Sep 30, 2022
Closed
@ganthern ganthern changed the title update electron to 20.3.0 update electron to 20.x.y Sep 30, 2022
@ganthern ganthern modified the milestones: 3.102.0, Technical tasks Oct 4, 2022
@ganthern ganthern self-assigned this Oct 4, 2022
@ganthern ganthern changed the title update electron to 20.x.y update electron to 21.1.1 Oct 17, 2022
ganthern added a commit that referenced this issue Oct 17, 2022
@ganthern
[maintenance] update electron to 21.1.1
56aaaa5 
also update electron-packager, electron-updater and electron-builder

this is a major version upgrade. relevant breaking change:
electronjs.org/docs/latest/breaking-changes#removed-skiptaskbar-on-linux

we do use it to hide the webDialog from the task bar during 2nd factor
login, but if it's removed we can live with it.

close #4623
@ganthern ganthern mentioned this issue Oct 17, 2022
Merged
@ganthern ganthern added the state:done meets our definition of done label Oct 18, 2022
@ganthern ganthern mentioned this issue Oct 20, 2022
Closed
charlag pushed a commit that referenced this issue Oct 27, 2022
@ganthern @charlag
[maintenance] update electron to 21.1.1
33bf55d 
also update electron-packager, electron-updater and electron-builder

this is a major version upgrade. relevant breaking change:
electronjs.org/docs/latest/breaking-changes#removed-skiptaskbar-on-linux

we do use it to hide the webDialog from the task bar during 2nd factor
login, but if it's removed we can live with it.

close #4623
@charlag charlag assigned charlag and unassigned ganthern Oct 27, 2022
@charlag charlag mentioned this issue Nov 1, 2022
Closed
1 task
@ganthern ganthern assigned charlag and unassigned charlag Nov 2, 2022
@charlag charlag added the state:tested We tested it and are about to release it label Nov 2, 2022
@charlag charlag removed their assignment Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
desktop Desktop client related issues maintenance dependency updates, key renewals, code cleanup state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.103.3
2 participants
@charlag @ganthern