Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Recipients field hidden by auto suggestions #4725

Closed
9 tasks done
mpfau opened this issue Nov 8, 2022 · 0 comments · Fixed by #4803
Closed
9 tasks done

Calendar: Recipients field hidden by auto suggestions #4725

mpfau opened this issue Nov 8, 2022 · 0 comments · Fixed by #4803
Assignees
@nokhub
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Milestone
3.105.9

Comments

@mpfau
Copy link
Contributor

mpfau commented Nov 8, 2022 •
edited by nokhub

Bug in web app

Describe the bug
When typing a recipient name to an invitation, the actual recipients field is hidden by an auto suggest overlay:
hidden_recipients

To Reproduce
Steps to reproduce the behavior:

  1. Click on Calendar / New event
  2. Start typing into the recipients field

Expected behavior
The auto suggestions should be displayed below the field that the text is entered to.

Test Notes

this needs to be checked in all major browsers: chrome, firefox, safari, chrome on android, safari on ios, ios app, android app

  • check that the dropdown appears in the right place now
  • it's not being clipped by the expander panel
  • check that it's also correctly displayed in the mail editor's recipient fields
  • Expanders expand/collapse correctly:
    • mail viewer header
    • settings view
      • closed sessions
      • inbox rules
      • email addresses
      • notifications
      • audit log
@mpfau mpfau added the bug broken functionality, usability problems, unexpected errors label Nov 8, 2022
@kib42 kib42 added the ui visual glitches, missing buttons, wrong text... label Nov 9, 2022
@ganthern ganthern self-assigned this Nov 30, 2022
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
a935c15 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown.

fix #4725
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
f10624a 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything anyway.

fix #4725
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
21abe88 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything in any browser (the issue
mentioned in f979613 was visible in the
new mailviewer header expander, but it's currently not anymore even
without the overflow: hidden

fix #4725
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
86f41b0 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything in any browser (the issue
mentioned in f979613 was visible in the
new mailviewer header expander, but it's currently not anymore even
without the overflow: hidden)

fix #4725
@ganthern ganthern mentioned this issue Dec 1, 2022
Merged
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
f9dffa6 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything in any browser (the issue
mentioned in f979613 was visible in the
new mailviewer header expander, but it's currently not anymore even
without the overflow: hidden)

fix #4725
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
886efb9 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything in any browser (the issue
mentioned in f979613 was visible in the
new mailviewer header expander, but it's currently not anymore even
without the overflow: hidden)

fix #4725
ganthern added a commit that referenced this issue Dec 1, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
02fdaa7 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything in any browser (the issue
mentioned in f979613 was visible in the
new mailviewer header expander, but it's currently not anymore even
without the overflow: hidden)

fix #4725
@charlag charlag added the state:done meets our definition of done label Dec 2, 2022
@ganthern ganthern added this to the 3.106.0 milestone Dec 7, 2022
ganthern added a commit that referenced this issue Dec 7, 2022
@ganthern
fix suggestion dropdowns being positioned to random ancestor
4fa461d 
the suggestion dropdown is an absolutely positioned element,
these get positioned relative to the next positioned ancestor.

The MailRecipientsTextField did not come with its own
positioned element, so positioning of the dropdown depends
on the environment it's displayed in.

this commit adds a position: relative wrapper around the dropdown

also removes overflow: hidden from Expander since it's cutting off the
dropdown and doesn't seem to do anything in any browser (the issue
mentioned in f979613 was visible in the
new mailviewer header expander, but it's currently not anymore even
without the overflow: hidden)

fix #4725
@nokhub nokhub self-assigned this Dec 9, 2022
@nokhub nokhub added the state:tested We tested it and are about to release it label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nokhub nokhub

Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Projects
None yet
Milestone
3.105.9
Development

Successfully merging a pull request may close this issue.

Obscured recipients field tutao/tutanota
5 participants
@mpfau @charlag @ganthern @kib42 @nokhub