Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery code news item shows print button on mobile devices #4851

Closed
2 tasks done
nowhub opened this issue Dec 14, 2022 · 2 comments · Fixed by #4852
Closed
2 tasks done

Recovery code news item shows print button on mobile devices #4851

nowhub opened this issue Dec 14, 2022 · 2 comments · Fixed by #4852
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@nowhub
Copy link
Contributor

nowhub commented Dec 14, 2022

  • This is not a feature request (existing functionality does not work, not missing functionality).
    I will request features on forum or via support.
  • I've searched and did not find a similar issue.

Bug in mobile app

Describe the bug
The recovery code news item shows a print button that does nothing on mobile devices.

To Reproduce
Steps to reproduce the behavior:

  1. Open the news dialog
  2. Click show the recovery code on the recovery code news item
  3. Observe that "print" button is displayed

Expected behavior
I expect the print button to either open a print dialog or to not be there if the mobile OS does not support printing.

Smartphone (please complete the following information):

  • iOS 16.2
  • Tutanota ver. 3.105.4
@nowhub nowhub added the bug broken functionality, usability problems, unexpected errors label Dec 14, 2022
@nowhub
Copy link
Contributor Author

nowhub commented Dec 14, 2022

Test notes

  • Create the news item recoveryCode, make sure that it is active
  • Confirm that the print button is shown in desktop apps and web
  • Confirm that the print button is not shown in mobile apps

@ganthern
Copy link
Contributor

note: #4843

@ganthern ganthern added the state:done meets our definition of done label Dec 14, 2022
@ganthern ganthern added this to the 3.106.x milestone Dec 19, 2022
@wrdhub wrdhub added the state:tested We tested it and are about to release it label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants