Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete folder structures #4861

Closed
3 tasks done
Tracked by #927
bedhub opened this issue Dec 16, 2022 · 0 comments · Fixed by #4931
Closed
3 tasks done
Tracked by #927

Delete folder structures #4861

bedhub opened this issue Dec 16, 2022 · 0 comments · Fixed by #4931
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@bedhub
Copy link
Contributor

bedhub commented Dec 16, 2022

As a user, I want to be able to delete a whole folder hierarchy so I don't have to delete each subfolder one by one .

As a user, I want the deleted folder to appear as-is in the trash folder until the 30 day period is over so I can restore the hierarchy if I made a mistake or change my mind.

AC

  • Deletion is just moving to trash (any deleted item becomes a direct child of the trash, preserving the rest of the hierarchy)
  • Folders and contents are deleted recursively after the 30 days grace period
  • When the folder is empty (no subfolder no mails) we delete it directly
  • Move and cleanup rules apply to the spam folder

Implementation hints

Folder Cleanup works as follows:

  • we have to store the move (or creation) time on each folder.
  • Adapt batch job (CleanupOldMailsBatchJob.java) to inspect every folder that is a descendant of the trash for its move time
  • if that is >30 days (folder deletion time), delete all mail inside that also has a move time of >30 days (it was here in the trash for at least 30 days)
  • remove folder if it's empty now. (no mails no sub folders)

Notes

  • consider inbox rules that target the deleted folders.
  • consider mails that are moved to a deleted folder

Test Notes

  • Selecting delete on custom folder that isn't in trash folder moves folder to trash
    • any empty folders in the trashed folder get removed
  • Selecting delete on custom folder that is in trash folder deletes folder
@bedhub bedhub added the new feature user stories in varying refinement states label Dec 16, 2022
@bedhub bedhub changed the title Move folder structures to Trash Delete folder structures Dec 16, 2022
@bedhub bedhub mentioned this issue Dec 16, 2022
4 tasks
@bedhub bedhub added subfolders and removed new feature user stories in varying refinement states labels Dec 23, 2022
@wrdhub wrdhub self-assigned this Dec 29, 2022
wrdhub added a commit that referenced this issue Jan 4, 2023
wrdhub added a commit that referenced this issue Jan 4, 2023
wrdhub added a commit that referenced this issue Jan 5, 2023
@wrdhub wrdhub added the state:done meets our definition of done label Jan 10, 2023
@ganthern ganthern added this to the 3.108.0 milestone Jan 16, 2023
@charlag charlag self-assigned this Jan 23, 2023
@charlag charlag added the state:tested We tested it and are about to release it label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants