Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Body Missing #5221

Closed
6 tasks done
Optomod opened this issue Mar 3, 2023 · 8 comments · Fixed by #5230
Closed
6 tasks done

Email Body Missing #5221

Optomod opened this issue Mar 3, 2023 · 8 comments · Fixed by #5230
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@Optomod
Copy link

Optomod commented Mar 3, 2023

  • This is not a feature request (existing functionality does not work, not missing functionality).
    I will request features on forum or via support.
  • I've searched and did not find a similar issue.

Bug in web app

Describe the bug
Message body does not load, tries to but then show three dots as of two releases "refreshs" ago.

To Reproduce
Load web version of Tutanota

Expected behavior
Message body does not load, tries to but then show three dots as of two releases "refreshs" ago.

Screenshots
Screen Shot 2023-03-03 at 5 32 17 pm

Desktop (please complete the following information):

  • OS: OSX
  • Browser Firefox
  • Version [78.15

Test notes

Test that all supported platforms still work:

  • Firefox ESR
  • Chrome
  • Safari/iOS app (ideally the older one in simulator)
  • Android app
@Optomod Optomod added the bug broken functionality, usability problems, unexpected errors label Mar 3, 2023
@ganthern
Copy link
Contributor

ganthern commented Mar 3, 2023

Hey there,

Firefox v78 is quite outdated and outside of our Browser support policy. Please try updating your browser and let us know if the issue persists.

https://tutanota.com/blog/posts/browser-support

@ganthern ganthern closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2023
@ganthern ganthern added the state:wontfix issues that are not significant enough to invest in or that are intended behaviour label Mar 3, 2023
@kib42
Copy link

kib42 commented Mar 3, 2023

Unfortunately I think that the issue affects modern browsers on moderns systems. However I was not able to reproduce it.

There also have been reports of this happening on Android

@kib42 kib42 reopened this Mar 3, 2023
@kib42 kib42 removed the state:wontfix issues that are not significant enough to invest in or that are intended behaviour label Mar 3, 2023
@charlag
Copy link
Contributor

charlag commented Mar 6, 2023

@Optomod could you please send us logs via settings -> about to hello@tutao.de after it happens? We are struggling to reproduce it. Thank you!

@charlag
Copy link
Contributor

charlag commented Mar 6, 2023

We've checked the code and it can't really happen in normal circumstances that click event handler fails. We suspect there is an uncaught error during the rendering pass and lifecycle methods are not actually called but we haven't seen any uncaught errors in the logs.

So far from the error reports we've noticed few cases:

  • it is an old browser
  • it is in multi search viewer or after it
  • it is iOS 16.3

@charlag
Copy link
Contributor

charlag commented Mar 6, 2023

judging by #5214 this is what happens:

so the end result is that the whole class of issues is invisible to us

charlag added a commit that referenced this issue Mar 6, 2023
We've discovered that mithril is swallowing up all uncaught errors
and is just logging them. This might be the best solution in some cases
where the app would be completely unusable otherwise. We can't do much
about it at the moment.

Additionally, console object was bound too early for us to add these
errors in the logger. To address this we've patched mithril so that it
doesn't keep its own copy.

#5221
charlag added a commit that referenced this issue Mar 6, 2023
@nokhub nokhub added the state:done meets our definition of done label Mar 7, 2023
charlag added a commit that referenced this issue Mar 9, 2023
We've discovered that mithril is swallowing up all uncaught errors
and is just logging them. This might be the best solution in some cases
where the app would be completely unusable otherwise. We can't do much
about it at the moment.

Additionally, console object was bound too early for us to add these
errors in the logger. To address this we've patched mithril so that it
doesn't keep its own copy.

#5221
@charlag charlag added this to the v3.110.1 milestone Mar 9, 2023
charlag added a commit that referenced this issue Mar 9, 2023
@wrdhub wrdhub self-assigned this Mar 10, 2023
@wrdhub wrdhub added the state:tested We tested it and are about to release it label Mar 10, 2023
@wrdhub wrdhub removed their assignment Mar 10, 2023
@nikoPLP
Copy link

nikoPLP commented Mar 11, 2023

see my comment in a related issue #5246 (comment)

@FlavioMala
Copy link

FlavioMala commented Mar 18, 2023

Now it is no longer possible to log in from my phone with SO UBports (Ubuntu touch)...
(I also opened an issue here, if helpful :https://gitlab.com/ubports/development/core/morph-browser/-/issues/549 )

And there are no alternative browsers: I tried Onion browsers and others available on OpenStore... and also those that can be installed with Libertine (Midori, Firefox, etc.)

So it seems that now all those who have "UBports" phones can no longer access Tutanota!

Will it be when 20.04 (now UBports based on Ubuntu 16.04) is available? Who knows? And it will take months…years… ?
Isn't an exception possible for UBports?

Alternatively the only workaround that comes to my mind is to evaluate another email and leave Tutanota...

@xaur
Copy link

xaur commented May 5, 2023

The fix in #5230 added CSS test document.querySelector("blockquote:not(blockquote blockquote)") which requires Selectors Level 4 implemented by the browser (according to this article)

This is supported in browser versions starting from Chrome 88, Firefox 84, and Safari 9.

It is fair to unsupport old browsers and not let them use the app. The only problem is it prevents login, and if you don't login for 6 months you lose the account. Ideally the more advanced compatibility checks would run after login to at least let older clients keep the account alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants