Return after catching UpgradeRequiredError #5662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix re-throwing UpgradeRequiredError when adding an alias from the custom domain wizard. tutadb#1569
charlag
reviewed
Jul 25, 2023
| @@ -184,6 +184,7 @@ export class AddEmailAddressesPageAttrs implements WizardPageAttrs<AddDomainData | |||
| return false | |||
| } else if (e instanceof UpgradeRequiredError) { | |||
| await showPlanUpgradeRequiredDialog(e.plans, e.message) | |||
| return false | |||
There was a problem hiding this comment.
that's what you get for not having an else case huh
There was a problem hiding this comment.
I mean, the else case would be throwing the error, so...
There was a problem hiding this comment.
yeah but you wouldn't just fallthrough to it
|
I would still do everything in each brunch but maybe this is better? |
Merged
|
Merged via #5794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix re-throwing UpgradeRequiredError when adding an alias from the custom domain wizard.
tutadb#1569