-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return after catching UpgradeRequiredError #5662
Conversation
Fix re-throwing UpgradeRequiredError when adding an alias from the custom domain wizard. tutadb#1569
@@ -184,6 +184,7 @@ export class AddEmailAddressesPageAttrs implements WizardPageAttrs<AddDomainData | |||
return false | |||
} else if (e instanceof UpgradeRequiredError) { | |||
await showPlanUpgradeRequiredDialog(e.plans, e.message) | |||
return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what you get for not having an else
case huh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, the else case would be throwing the error, so...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but you wouldn't just fallthrough to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this better, then, @charlag?
I would still do everything in each brunch but maybe this is better? |
Merged via #5794 |
Fix re-throwing UpgradeRequiredError when adding an alias from the custom domain wizard.
tutadb#1569