Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible reminder times #5712

Closed
13 tasks done
vitoreiji opened this issue Aug 1, 2023 · 0 comments · Fixed by #6041
Closed
13 tasks done

Flexible reminder times #5712

vitoreiji opened this issue Aug 1, 2023 · 0 comments · Fixed by #6041
Labels
improvement nice-to-haves that are not impeding usage of any features state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar
Milestone
3.118.24

Comments

@vitoreiji
Copy link
Contributor

vitoreiji commented Aug 1, 2023 •
edited by rezbyte

As a calendar user, I would like to be able to set my alarms flexibly exactly as I need them before the event starts so I'm not restricted to a few options that may not be useful to me.

AC

  • the old alarm options are still available as a quick way to set alarms
  • there is an option to add a reminder when the event occurs
  • there's also an option to add a custom alarm in the event editor
    • this option opens a new dialog with a field for amount of time units and a dropdown to select the time unit (minutes, hours, days, weeks)
    • the amount text field is restricted to non-negative integers (zero is valid)
  • alarms are still deduplicated
  • the alarms still fire according to the configured trigger

Release notes

Must be released after #5711 to prevent confusion.

Tasks

  • Add a preconfigured option to show reminder at the time of the event (0 seconds)
    • Have human-readable text for it
    • Test it on all platforms
  • Implement a new dialog for selecting specific amount and unit for reminder trigger
  • Add an option to select custom time
  • Implement deduplication of reminders

Test Notes

  • Mail Notifications still working
  • Alarms for events still working
  • The pre defined intervals still there
  • The pre defined intervals work and de-duplicate correctly with the custom ones
  • There is an option for custom interval
  • The custom interval works
  • Multiples alarms defined while creating the event works
@vitoreiji vitoreiji added improvement nice-to-haves that are not impeding usage of any features topic: calendar labels Aug 1, 2023
@vitoreiji vitoreiji mentioned this issue Aug 1, 2023
Closed
@bedhub bedhub changed the title Flexible alarm times Flexible reminder times Oct 10, 2023
@ganthern ganthern mentioned this issue Oct 25, 2023
Open
14 tasks
@murilopereirame murilopereirame self-assigned this Oct 25, 2023
murilopereirame pushed a commit that referenced this issue Oct 26, 2023
implement flexible reminder times
255202d 
When the users create a new event in calendar, they have just some
pre-defined options, not being able to set up a custom time, like
three minutes.

This commit adds an option in reminder alarm dropdown to users input a
custom interval for the alarm, being able to set any positive integer
and selecting any unit between Minutes, Hours, Days or Weeks.

implements #5712
murilopereirame pushed a commit that referenced this issue Oct 26, 2023
fix web scheduling just one alarm
2a7d203 
When the user create an event with a reminder, it was scheduling only
the first reminder and ignoring the others.

This commit fix this issue, removing the return statement, the for
iterator is completed instead of skipping after the first create
iteration.

related to #5712
@murilopereirame murilopereirame mentioned this issue Oct 26, 2023
Merged
@ganthern ganthern added the state:done meets our definition of done label Nov 1, 2023
@wrdhub wrdhub added this to the 3.118.23 milestone Nov 1, 2023
wrdhub pushed a commit that referenced this issue Nov 1, 2023
@wrdhub
implement flexible reminder times
6e45f08 
When the users create a new event in calendar, they have just some
pre-defined options, not being able to set up a custom time, like
three minutes.

This commit adds an option in reminder alarm dropdown to users input a
custom interval for the alarm, being able to set any positive integer
and selecting any unit between Minutes, Hours, Days or Weeks.

implements #5712
wrdhub pushed a commit that referenced this issue Nov 1, 2023
@wrdhub
fix web scheduling just one alarm
fcc8961 
When the user create an event with a reminder, it was scheduling only
the first reminder and ignoring the others.

This commit fix this issue, removing the return statement, the for
iterator is completed instead of skipping after the first create
iteration.

related to #5712
@rezbyte rezbyte self-assigned this Nov 2, 2023
@rezbyte rezbyte added the state:tested We tested it and are about to release it label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement nice-to-haves that are not impeding usage of any features state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar
Projects
None yet
Milestone
3.118.24
Development

Successfully merging a pull request may close this issue.

Flexible reminder times tutao/tutanota
5 participants
@vitoreiji @ganthern @murilopereirame @rezbyte @wrdhub