Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event sometimes not displaying fully after an update #5896

Closed
7 tasks done
jalhubb opened this issue Sep 18, 2023 · 2 comments · Fixed by #5904
Closed
7 tasks done

Event sometimes not displaying fully after an update #5896

jalhubb opened this issue Sep 18, 2023 · 2 comments · Fixed by #5904
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it topic: calendar ui visual glitches, missing buttons, wrong text...
Milestone
3.118.12

Comments

@jalhubb
Copy link

jalhubb commented Sep 18, 2023 •
edited by charlag

Events between February and March 2024 are not displayed properly

To Reproduce
Steps to reproduce the behavior:

  1. Go to Calendar
  2. Create Event between February and March (for example 26th February - 06th March 2024)
  3. The event will only display until 03rd of March

Screenshots
image

Additional context
I could not identify the clear edges as if the event is longer or adjusting the start/end date sometimes does not reproduce.
The issue was reproduce-able on Desktop & Mobile

Test Notes
@jalhubb jalhubb added bug broken functionality, usability problems, unexpected errors topic: calendar desktop Desktop client related issues labels Sep 18, 2023
@ganthern ganthern added the ui visual glitches, missing buttons, wrong text... label Sep 18, 2023
@ganthern
Copy link
Contributor

possibly related to #5839

@ganthern
Copy link
Contributor

this only happens right after adding the event, correct? reloading the calendar page fixes the display for me.

ganthern added a commit that referenced this issue Sep 19, 2023
@ganthern
fix short events not being displayed sometimes in the 6th week row
a8a2ef7 
we changed addDaysForEventInstance to only worry about the month it
was called for and ignore the rest of the event that may extend to the
next month, but did not adapt CalendarViewModel._addOrUpdateEvent
to also add short events to the month where they end.

in cases where we
* receive an entity event update for a short event that starts in the
  current month but ends in the next
* the month view displays a complete week that is part of the next month
  at the bottom (to fill the 6x7 grid)

we would therefore not display that events end.

fix #5896
fix #5839
fix 3a68f20
This was referenced Sep 19, 2023
Merged
Closed
@ganthern ganthern self-assigned this Sep 19, 2023
@ganthern ganthern changed the title event not displaying properly during leap-year event sometimes not displaying properly at month end Sep 19, 2023
@ganthern ganthern added the state:done meets our definition of done label Sep 20, 2023
@charlag charlag modified the milestone: 3.118.9 Sep 21, 2023
@ganthern ganthern mentioned this issue Sep 22, 2023
Closed
2 tasks
@charlag charlag added this to the 3.118.9 milestone Sep 22, 2023
charlag pushed a commit that referenced this issue Sep 22, 2023
@ganthern @charlag
fix short events not being displayed sometimes in the 6th week row
4ab33b3 
we changed addDaysForEventInstance to only worry about the month it
was called for and ignore the rest of the event that may extend to the
next month, but did not adapt CalendarViewModel._addOrUpdateEvent
to also add short events to the month where they end.

in cases where we
* receive an entity event update for a short event that starts in the
  current month but ends in the next
* the month view displays a complete week that is part of the next month
  at the bottom (to fill the 6x7 grid)

we would therefore not display that events end.

fix #5896
fix #5839
fix 3a68f20
@charlag charlag changed the title event sometimes not displaying properly at month end Event sometimes not displaying fully after an update Sep 22, 2023
@charlag charlag removed the desktop Desktop client related issues label Sep 22, 2023
@charlag charlag assigned charlag and unassigned ganthern Sep 22, 2023
@ganthern ganthern removed the state:done meets our definition of done label Sep 22, 2023
@charlag charlag added the state:tested We tested it and are about to release it label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it topic: calendar ui visual glitches, missing buttons, wrong text...
Projects
None yet
Milestone
3.118.12
Development

Successfully merging a pull request may close this issue.

fix short events not being displayed sometimes in the 6th week row tutao/tutanota
3 participants
@charlag @ganthern @jalhubb