Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

< becomes &lt in event title #5897

Closed
jalhubb opened this issue Sep 18, 2023 · 1 comment · Fixed by #5941
Closed

< becomes &lt in event title #5897

jalhubb opened this issue Sep 18, 2023 · 1 comment · Fixed by #5941
Labels
state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar ui visual glitches, missing buttons, wrong text...
Milestone
3.118.28

Comments

@jalhubb
Copy link

jalhubb commented Sep 18, 2023

Describe the bug
Issue with "<" and HTML escaping in event title

To Reproduce
Steps to reproduce the behavior:

  1. Go to Calendar
  2. Create event
  3. Put "<" in title
  4. See &lt instead

Additional context
This does not occur with any other characters or other places as far as tested
@jalhubb jalhubb added bug broken functionality, usability problems, unexpected errors topic: calendar labels Sep 18, 2023
@jalhubb jalhubb changed the title < becomes &lt in calendar title < becomes &lt in event title Sep 18, 2023
@ganthern ganthern added ui visual glitches, missing buttons, wrong text... and removed bug broken functionality, usability problems, unexpected errors labels Sep 18, 2023
paw-hub added a commit that referenced this issue Sep 27, 2023
@paw-hub
Don't run calendar location/title through HTML sanitization - #5897
c82fe19 
These fields will not be rendered as HTML, so we don't need to use any
sort of HTML sanitization for input.

Fixes #5897
@paw-hub paw-hub mentioned this issue Sep 27, 2023
Merged
@paw-hub paw-hub self-assigned this Sep 27, 2023
@paw-hub
Copy link
Contributor

paw-hub commented Sep 27, 2023 •
edited by charlag

Test notes

  • Create a calendar event. Type <b>Title</b> into the title, and <i>Location</i> into the location of a calendar event.
  • Verify that <> isn't replaced with any HTML entities, and that <b>Title</b> is displayed on the title of the editor
  • Save and quickly view the event. Verify that the title and location still show up as <b>Title</b> and <i>Location</i> respectively, and verify that this still holds true when editing the event.

paw-hub added a commit that referenced this issue Sep 27, 2023
@paw-hub
Don't run calendar location/title through HTML sanitization - #5897
16512ea 
These fields will not be rendered as HTML, so we don't need to use any
sort of HTML sanitization for input.

Fixes #5897
ganthern pushed a commit that referenced this issue Nov 13, 2023
@paw-hub @ganthern
Don't run calendar location/title through HTML sanitization - #5897
1b214c1 
These fields will not be rendered as HTML, so we don't need to use any
sort of HTML sanitization for input.

Fixes #5897
@ganthern ganthern added this to the 3.118.28 milestone Nov 13, 2023
@ganthern ganthern added the state:done meets our definition of done label Nov 13, 2023
ganthern pushed a commit that referenced this issue Nov 13, 2023
@paw-hub @ganthern
Don't run calendar location/title through HTML sanitization - #5897
375f86f 
These fields will not be rendered as HTML, so we don't need to use any
sort of HTML sanitization for input.

Fixes #5897
ganthern pushed a commit that referenced this issue Nov 13, 2023
@paw-hub @ganthern
Don't run calendar location/title through HTML sanitization - #5897
8d55a12 
These fields will not be rendered as HTML, so we don't need to use any
sort of HTML sanitization for input.

Fixes #5897
@charlag charlag self-assigned this Nov 14, 2023
@charlag charlag added the state:tested We tested it and are about to release it label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar ui visual glitches, missing buttons, wrong text...
Projects
None yet
Milestone
3.118.28
Development

Successfully merging a pull request may close this issue.

Don't run calendar location/title through HTML sanitization - #5897 tutao/tutanota
4 participants
@charlag @ganthern @paw-hub @jalhubb