Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a template list causes SessionKeyNotFoundError #6205

Closed
9 tasks done
charlag opened this issue Nov 27, 2023 · 0 comments · Fixed by #6368
Closed
9 tasks done

Creating a template list causes SessionKeyNotFoundError #6205

charlag opened this issue Nov 27, 2023 · 0 comments · Fixed by #6368
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.122.3

Comments

@charlag
Copy link
Contributor

charlag commented Nov 27, 2023 •
edited by paw-hub

Bug in web app

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Have no template
  2. Open template list
  3. Click add button
  4. See error

Context
We are creating a template list and trying to load TemplateGroupRoot right away, before we have downloaded a user with updated memberships. We should reloadUser() in GroupManagementFacade.createTemplateGroup() like in GroupManagementFacade.createContactListGroup().

Test Notes

  • The error doesn't happen anymore
  • Users still able to create templates
  • If the user is allowed to create a template, the contact admin message isn't shown
  • As a global admin
    • With Unlimited plan, the user can create a template
    • With any other plan, the user receives an upgrade dialog
  • As an user
    • With Unlimited plan, the user can create a template
    • With any other plan, the user receives a messaging asking to contact the plan admin
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Nov 27, 2023
@charlag charlag mentioned this issue Nov 27, 2023
Closed
3 tasks
@murilopereirame murilopereirame self-assigned this Jan 11, 2024
murilopereirame added a commit that referenced this issue Jan 11, 2024
@murilopereirame
Fix creating a template list causes SessionKeyNotFoundError
f74beb3 
Seems that the problem have already been fixed, but this commit
implements the changes suggested in the issue.

Also, fixes a bug that the contactAdmin_msg was displayed even when the
user was the global admin or user was allowed to create a template. This
wasn't preventing real allowed users from creating templates.

close #6205
@murilopereirame murilopereirame mentioned this issue Jan 11, 2024
Merged
@charlag charlag added the state:done meets our definition of done label Jan 19, 2024
@murilopereirame murilopereirame added this to the 3.121.X milestone Jan 29, 2024
@murilopereirame murilopereirame removed their assignment Feb 1, 2024
murilopereirame added a commit that referenced this issue Feb 1, 2024
@murilopereirame
Fix creating a template list causes SessionKeyNotFoundError
7042a30 
Seems that the problem have already been fixed, but this commit
implements the changes suggested in the issue.

Also, fixes a bug that the contactAdmin_msg was displayed even when the
user was the global admin or user was allowed to create a template. This
wasn't preventing real allowed users from creating templates.

close #6205
murilopereirame added a commit that referenced this issue Feb 5, 2024
@murilopereirame
Fix creating a template list causes SessionKeyNotFoundError
dcab034 
Seems that the problem have already been fixed, but this commit
implements the changes suggested in the issue.

Also, fixes a bug that the contactAdmin_msg was displayed even when the
user was the global admin or user was allowed to create a template. This
wasn't preventing real allowed users from creating templates.

close #6205
murilopereirame added a commit that referenced this issue Feb 5, 2024
@murilopereirame
Fix creating a template list causes SessionKeyNotFoundError
ed3db28 
Seems that the problem have already been fixed, but this commit
implements the changes suggested in the issue.

Also, fixes a bug that the contactAdmin_msg was displayed even when the
user was the global admin or user was allowed to create a template. This
wasn't preventing real allowed users from creating templates.

close #6205
@paw-hub paw-hub self-assigned this Feb 6, 2024
@paw-hub paw-hub added the state:tested We tested it and are about to release it label Feb 6, 2024
@paw-hub paw-hub removed their assignment Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.122.3
Development

Successfully merging a pull request may close this issue.

Fix creating a template list causes SessionKeyNotFoundError tutao/tutanota
3 participants
@charlag @murilopereirame @paw-hub