Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with .desktop file for Linux #6335

Closed
6 tasks done
chris9740 opened this issue Dec 28, 2023 · 0 comments · Fixed by #6361
Closed
6 tasks done

Error with .desktop file for Linux #6335

chris9740 opened this issue Dec 28, 2023 · 0 comments · Fixed by #6361
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@chris9740
Copy link

chris9740 commented Dec 28, 2023

  • This is not a feature request (existing functionality does not work, not missing functionality).
    I will request features on forum or via support.
  • I've searched and did not find a similar issue.

Describe the bug
The Icon key inside the .desktop file for Linux is invalid. The value is currently tutanota-desktop.png, but as per the Icon Theme Specification, it should not contain a file extension if it's not an absolute path. This causes the icon to not load.

Link to offending line of code

To Reproduce
Steps to reproduce the behavior:

  1. Install Tutanota
  2. Open the "quick launcher" (WIN key)
  3. Search Tutanota
  4. The result should show the Tutanota application with a placeholder icon

You can also run desktop-file-validate ~/.local/share/applications/tutanota-desktop.desktop, which should error with:

error: (will be fatal in the future): value "tutanota-desktop.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path

Expected behavior
The icon should load.

Screenshots
image

Desktop (please complete the following information):

  • OS: Pop!_OS 22.04 LTS
  • Desktop Environment: gnome
  • Version: v3.119.10

Additional context
I tried simply removing the .png from the .desktop file and it resolves the issues

Test Notes

  • Running desktop-file-validate on the clients .desktop passes without any errors or warnings
  • The icon still appears under
    • GNOME
    • KDE
@chris9740 chris9740 added bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues labels Dec 28, 2023
@rezbyte rezbyte self-assigned this Jan 9, 2024
rezbyte added a commit that referenced this issue Jan 9, 2024
rezbyte added a commit that referenced this issue Jan 9, 2024
Applied the suggestion by @chris9740 on #6335.
Updated the relevant test.
@ganthern ganthern added the state:done meets our definition of done label Jan 10, 2024
@ganthern ganthern added this to the 3.120.6 milestone Jan 10, 2024
rezbyte added a commit that referenced this issue Jan 12, 2024
Applied the suggestion by @chris9740 on #6335.
Updated the relevant test.
murilopereirame pushed a commit that referenced this issue Jan 18, 2024
Applied the suggestion by @chris9740 on #6335.
Updated the relevant test.
murilopereirame pushed a commit that referenced this issue Jan 18, 2024
Applied the suggestion by @chris9740 on #6335.
Updated the relevant test.
@murilopereirame murilopereirame self-assigned this Jan 19, 2024
@murilopereirame murilopereirame added the state:tested We tested it and are about to release it label Jan 19, 2024
@murilopereirame murilopereirame removed their assignment Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants