Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gift cards can not be displayed and used #6375

Closed
armhub opened this issue Jan 15, 2024 · 0 comments · Fixed by #6376
Closed

Gift cards can not be displayed and used #6375

armhub opened this issue Jan 15, 2024 · 0 comments · Fixed by #6376
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
3.120.6

Comments

@armhub
Copy link
Contributor

armhub commented Jan 15, 2024

There are different ways how to reproduce the error:

  1. Order a new gift card
    -> An error dialog is shown with the message "Invalid gift card key".
    Expected: The bought gift card is displayed

  2. Select to show a (newly created) gift card
    -> An error dialog is shown with the message "Invalid gift card key".
    Expected: The selected gift card is displayed

  3. Paste a (newly created) gift card link into the browser
    -> An error message dialog is shown informing the user that the gift card link is invalid.
    Expected: The gift card redeem dialog is shown
@armhub armhub added the bug broken functionality, usability problems, unexpected errors label Jan 15, 2024
@armhub armhub added this to the 3.120.6 milestone Jan 15, 2024
armhub added a commit that referenced this issue Jan 15, 2024
@armhub
Fix displaying gift cards, closes #6375
4a938e8 
The code did not consider 256 bit keys for gift cards.
@armhub armhub linked a pull request Jan 15, 2024 that will close this issue
Fix displaying gift cards, closes #6375 #6376
Merged
@armhub armhub added the state:done meets our definition of done label Jan 15, 2024
@armhub armhub closed this as completed Jan 15, 2024
wrdhub pushed a commit that referenced this issue Jan 15, 2024
@armhub @wrdhub
Fix displaying gift cards, closes #6375
ae81a0a 
The code did not consider 256 bit keys for gift cards.
@wrdhub wrdhub added the state:tested We tested it and are about to release it label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.120.6
Development

Successfully merging a pull request may close this issue.

Fix displaying gift cards, closes #6375 tutao/tutanota
2 participants
@armhub @wrdhub