Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Occurrence of Repeating all day events do not get removed #6491

Closed
2 tasks done
wrdhub opened this issue Feb 6, 2024 · 1 comment · Fixed by #6643
Closed
2 tasks done

Deleted Occurrence of Repeating all day events do not get removed #6491

wrdhub opened this issue Feb 6, 2024 · 1 comment · Fixed by #6643
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it state:tested-with-comments Issue has been tested but some issues were found and needs review. topic: calendar
Milestone

Comments

@wrdhub
Copy link
Contributor

wrdhub commented Feb 6, 2024

Describe the bug
When I delete one occurence of a repeating event (it is an all day event), the occurence stays visible until I log out and log in again.

Brought to attention github user: Cer41Tom in discussion

To Reproduce
Steps to reproduce the behavior:

  1. Create a repeating event that is all-day.
  2. Delete a single instance, instance will remain there.

Expected behavior
The instance to be removed immediately, like events that have a set time.

Test Notes

Test all with an all day event and an event that is at a set time

  • Create a repeating event, remove instances and see that they are removed
  • Create a repeating event and move one instance, see that it is moved and no event is left at the original time/date
@wrdhub wrdhub added bug broken functionality, usability problems, unexpected errors topic: calendar labels Feb 6, 2024
@wrdhub wrdhub self-assigned this Feb 20, 2024
wrdhub added a commit that referenced this issue Mar 1, 2024
Took out some code that was no longer useful. Long events are now always

taken out when updated, the new event will automatically be filled in.

close #6491
close #6444

Co-authored-by: ivk <ivk@tutao.de>
@charlag charlag added this to the Contact Sync milestone Mar 1, 2024
@charlag charlag added the state:done meets our definition of done label Mar 4, 2024
murilopereirame pushed a commit that referenced this issue Mar 13, 2024
Took out some code that was no longer useful. Long events are now always

taken out when updated, the new event will automatically be filled in.

close #6491
close #6444

Co-authored-by: ivk <ivk@tutao.de>
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2024
* Added vCard import to attachments

Now, when user receives a vCard as attachment an import option is
displayed inside the attachment bubble, allowing the user to preview
and import the users contained inside that vCard.

The app handles both vCard mime types, text/vcard and text/x-vcard.

* [android] Added vCard Handling

* [android] Added readDataFile

* [ios] Fix iOS readFile function

The iOS readFile function was using the wrong Data constructor,
leading to an Error related to invalid URL when trying to read the file.

The readFile function now uses the Data(fileURLWithPath: ) instead of
Data(contentsOf: ), allowing us to pass file paths to be loaded.

* Add view file handling from native side to app's web part

Now the app is capable to handle native side calls asking for importing
files, mainly used when a user view a supported file and want that Tuta
app handles it.

Currently, the only supported format is .vcf and only on Android, since
iOS doesn't support setting our app as a handler for vcf files.

* Make array readonly

* Create ContactFacade

Implements a ContactFacade to communicate with the worker and handle
errors correctly.

* Show contact icon when attachment is a vCard file

* Add ContactFacadeTest

* Changes after review

* Moved vCard parsing logic to ContactImporter

* Create ContactImporter class

* [android] Fix readDataFile to read on I/O thread

* Implement device contacts import

Close #6467

Co-authored-by: mup <mup@tutao.de>
Co-authored-by: ivk <ivk@tutao.de>

* Fix importing contacts from Device book on Android

* Don't show incorrect mail address info on legacy plans

It is not true that legacy plans can have unlimited custom domains. Make
it not display anything here to prevent confusion.

Fixes #6540

* Changes after review

* Implement device contacts import

Close #6467

Co-authored-by: mup <mup@tutao.de>
Co-authored-by: ivk <ivk@tutao.de>

* Get Dirty info from contact on Android

This commit adds the isDirty property to a contact and return Dirty
contacts to the web part of the app, allowing the app to deal with
native updates.

* Handle native contact Updates

This commit adds a handler to deal with contacts that were added or
edited through the native. If created, inserts the new contact into the
server, otherwise, updates it.

* Apply contact deletion from native side

When user deletes a contact from the native side, the deletion is
applied to the server

* Adjust iOS types

* [android] Two-way contact sync on Android

* Reset Contact's dirty state during Contact update

* Two-way contact sync on iOS

* Fix nickname and deletedOnDevice

* Fix preview list scroll issue

* Don't show incorrect mail address info on legacy plans

It is not true that legacy plans can have unlimited custom domains. Make
it not display anything here to prevent confusion.

Fixes #6540

* Add new fields to Contact

This commit add new fields described in #6590 to the model and adapts
the ContactEditor and ContactViewer to handle the new fields.

* [android] Added new fields to Android Contact Import

* Fix Xcode warning for TaggedSqlValue

* [ios] Add new contact fields to iOS

* Add new fields to vCard

This commit adds the following fields:
- Middle Name
- Name Suffix
- Department (Inside ORG)
- URL

The field ROLE was changed to TITLE since that TITLE seems to be the
expected name for this field.

* Fix tests and add translations

This commit fixes the vCard import/export tests and adds the missing
translations for DE and DE_SIE.

* Code cleanup

* Code cleanup

* Fix bugs from review

* Reset selection in contact list view when deleting selected contents

Call selectNone on the list model to clear the selection after deleting
a selection of contacts.

Fixes #6623

* Fix wrong label on new event button tooltip

This should be newEvent_action; createEvent_label is used as a
placeholder for when the event name is empty in the edit event dialog.

Fixes #6626

* Lower the minimized mail editor overlay

The overlay was position a bit too high due to the recent
overlay changes.

* Events are removed immediately when deleting single or changing rules

Took out some code that was no longer useful. Long events are now always

taken out when updated, the new event will automatically be filled in.

close #6491
close #6444

Co-authored-by: ivk <ivk@tutao.de>

* Fix label in global settings clipping on mobile

* Makes version number copiable from about Dialog

This commit makes the Version Number, License and Company Name able
to be copied

fix #6605

* Fix SearchBar returning no results even with not enabled index

The users were able to trigger an empty search result even without
accepting to enable the search index. Now, even if the user tries
to bypass the dialog, the SearchBar will not return any result

fix #2689

* Fix Android unwanted auto login

This commit flags an intent that has already been handled by the
app as handled, avoiding that when the user opens the app an
intent re-deliver causes auto login.

fix #6322

* Fix client-side captcha verification; fix SignupFormTest

Fix Captcha matching hours 25-29 and allows it to match times that
will never be correct (but can be checked locally).

Add missing SignupFormTest to the test suite.

Fixes #6316

* Align all day events in the calendar on desktop

The ideal solution in my eyes is to rewrite the calendar header so that
the header and body for the day are in one column flex. Using flex
is better than constantly calculating the sizes of elements ourselves
both in code simplicity and performance.

Until then, this quick workaround seems to do the trick.

* Allow switching the calendar for accepted events

Co-authored-by: wec43 <wec@tutao.de>

* Change default email domain when adding email address on legacy plan

fix #6667

* Tell user they cannot add an alias before add alias dialog

* [ci, ios] Separate staging app for iOS

 - Introduce new schemes in iOS app for debug, staging and prod
 - Add new appId
 - Add jobs to get provisioning profiles/certificates for staging app
 - Introduce new Fastlane lanes
 - Add Jenkins steps to build/upload staging app

 Close #6591

* [android] Two-way contact sync on Android

* Fix an initial underscore being generated for Kotlin enum cases

Co-authored-by: paw-hub <104824185+paw-hub@users.noreply.github.com>

* Add an onboarding wizard prototype

This adds a guide that is displayed during the first run after
installing the app. This also includes it's first page,
the welcome page. This will be expanded upon in further commits.

The icon design still needs to be finalised, so
I have inserted a placeholder for now.

* Make the onboarding wizard show only on first run

This adds a property called `isSetupComplete` to `DeviceConfig` used to
determine whether the onboarding wizard has been displayed before.
The property is set to true after the wizard is completed or skipped
causing the wizard only to display once per install.

* Add notifications page to the Android version of the onboarding wizard

Includes the android implementation.

Co-authored-by: mup <mup@tutao.de>

* Fix `licc` generating incorrect code for enums

* Stop asking for notification permissions at launch

Co-authored-by: ivk <ivk@tutao.de>

* Add the theme page to the onboarding wizard

Co-authored-by: ivk <ivk@tutao.de>

* Create a wrapper for onboarding wizard pages

Co-authored-by: ivk <ivk@tutao.de>

* Add the contacts page to the onboarding wizard

Co-authored-by: ivk <ivk@tutao.de>

* Add the app lock page to the onboarding wizard

Co-authored-by: ivk <ivk@tutao.de>

* Enable back buttons in the onboarding wizard

* Implement the notifications page for iOS

Co-authored-by: paw-hub <104824185+paw-hub@users.noreply.github.com>

* Fix the next button overlapping the content in landscape view

I am not happy about the magic '92%' value but to remove it we would
need to calculate the remaining space from the breadcrumbs & dialog
height. This may do for now.

* Change the congratulations page header to 'Welcome to Tuta!'

We decided to change it during a meeting. This way we welcome the user
to the Tuta ecosystem instead of just the app.

* Change `RadioSelector` styling

This styles the `RadioSelector` into a 'radio button button' for the
lack of a better term. This was decided in a meeting.

* Remove skip button from onboarding wizard

* Fix the app lock page of the onboarding wizard having too much padding

* Change wizard breadcrumbs styling

This changes the breadcrumbs in the wizard to make the style discussed
during the meeting.

* Remove the help text from the lock method options in the onboarding flow

This is so the unlock method pages matches our design.

* Improve the text in the onboarding wizard

This tries to make the wizard less wordy & includes a couple
small fixes.

* Align buttons in the onboarding wizard

* Clean up the notification permission check on visibility change code

Co-authored-by: ivk <ivk@tutao.de>

* Use a smaller dialog for the onboarding wizard

Co-authored-by: ivk <ivk@tutao.de>

* Fix Android build breaking due to Kotlin JVM version

* Fix import errors

* Stop asking for notification permissions at launch on iOS

* Add the illustrations to the onboarding wizard

This needs some optimization as the illustrations cause the CSS
animations to lag. `Icons.ts` is not the best place to have the
illustrations so we should create a new file. We could also look at
sanitizing the SVGs once a way to keep the CSS classes in the SVG is
found.

* Disable the app lock page on the onboarding wizard if it is not needed

* Move the onboarding wizard illustrations into a separate file

The illustrations do not clutter up the icons file this way.

* Apply redesign of the onboarding wizard

This adds the next version of the illustrations and
changes some layouts.

* Optimise Onboarding Wizard Rendering

This tries to speed up the wait between pressing 'next' and the next
page of the onboarding wizard appearing.

* Bring back the visualizer plugin

We need it to diagnose chunk problems. It was removed because it was not
compatible with our version of `rollup` at the time.

Co-authored-by: ivk <ivk@tutao.de>

* Load the onboarding wizard's illustrations externally

As suggested by ivk, the illustrations are loaded in via an `img` tag
to avoid bloating the chunks. I have manually optimised and inserted the
illustrations again. This improves the performance of the wizard
drastically.

* Ignore the onboarding wizard's illustrations in screen readers

---------

Co-authored-by: mup <mrex@tuta.io>
Co-authored-by: paw <paw-hub@users.noreply.github.com>
Co-authored-by: mup <mup@tutao.de>
Co-authored-by: mac-github <mac-github@tutao.de>
Co-authored-by: mup <34790144+murilopereirame@users.noreply.github.com>
Co-authored-by: jat <jat@tutao.de>
Co-authored-by: wrd <wrd@tutao.de>
Co-authored-by: wec43 <wec@tutao.de>
Co-authored-by: tutao <hello@tutao.de>
Co-authored-by: paw-hub <104824185+paw-hub@users.noreply.github.com>
@ganthern ganthern self-assigned this Mar 14, 2024
@ganthern ganthern added state:tested-with-comments Issue has been tested but some issues were found and needs review. and removed state:done meets our definition of done labels Mar 14, 2024
@ganthern
Copy link
Contributor

When I create a daily repeating event I found some issues when dragging them in week view and day view:

  • after clicking "update this event only", the event doesn't get moved.
  • there's quite a bit of spam in the console.

Dragging them in month view works fine, as does dragging non-all-day events.

This occurs in firefox and the desktop client

@ganthern ganthern removed their assignment Mar 14, 2024
@wec43 wec43 self-assigned this Mar 14, 2024
@wec43 wec43 added the state:tested We tested it and are about to release it label Mar 14, 2024
@wec43 wec43 removed their assignment Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it state:tested-with-comments Issue has been tested but some issues were found and needs review. topic: calendar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants