Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain migration banner is shown on whitelabel domains #6496

Closed
3 tasks done
charlag opened this issue Feb 6, 2024 · 0 comments · Fixed by #6514
Closed
3 tasks done

Domain migration banner is shown on whitelabel domains #6496

charlag opened this issue Feb 6, 2024 · 0 comments · Fixed by #6514
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
218.240227.0

Comments

@charlag
Copy link
Contributor

charlag commented Feb 6, 2024 •
edited by paw-hub

We never check whether it is a whitelabel domain

Test notes

  • Go onto a whitelabel domain and verify that the migration banner does not appear.
  • Verify the banner is still not shown in the desktop/mobile apps.
  • Verify the banner is still shown when on the webapp login page (besides whitelabel domains, of course).
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Feb 6, 2024
@paw-hub paw-hub self-assigned this Feb 9, 2024
paw-hub added a commit that referenced this issue Feb 9, 2024
@paw-hub
Don't show MigratingCredentialsBanner outside of main webapp page
9fcb75a 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
@paw-hub paw-hub mentioned this issue Feb 9, 2024
Merged
paw-hub added a commit that referenced this issue Feb 9, 2024
@paw-hub
Don't show MigratingCredentialsBanner outside of main webapp page
60b53dc 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
paw-hub added a commit that referenced this issue Feb 9, 2024
@paw-hub
Don't show MigratingCredentialsBanner outside of main webapp page
cd2e8ae 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
paw-hub added a commit that referenced this issue Feb 9, 2024
@paw-hub
Don't show MigratingCredentialsBanner outside of main webapp page
3edd2a2 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
@paw-hub paw-hub changed the title Domain mirgation banner is shown on whitelabel domains Domain migration banner is shown on whitelabel domains Feb 12, 2024
@charlag charlag added the state:done meets our definition of done label Feb 13, 2024
@charlag charlag added this to the Next Product Team Release milestone Feb 20, 2024
charlag pushed a commit that referenced this issue Feb 26, 2024
@paw-hub @charlag
Don't show MigratingCredentialsBanner outside of main webapp page
fe2b9c7 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@paw-hub @charlag
Don't show MigratingCredentialsBanner outside of main webapp page
14dab3e 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
murilopereirame pushed a commit that referenced this issue Feb 26, 2024
@paw-hub @murilopereirame
Don't show MigratingCredentialsBanner outside of main webapp page
3b76f88 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
@paw-hub paw-hub assigned paw-hub and unassigned paw-hub Feb 27, 2024
@paw-hub paw-hub added the state:tested We tested it and are about to release it label Feb 27, 2024
@paw-hub paw-hub removed their assignment Feb 27, 2024
murilopereirame pushed a commit that referenced this issue Mar 1, 2024
@paw-hub @murilopereirame
Don't show MigratingCredentialsBanner outside of main webapp page
aa84042 
Prevent it from showing on whitelabel in addition to apps.

Fixes #6496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
218.240227.0
Development

Successfully merging a pull request may close this issue.

Don't show MigratingCredentialsBanner outside of main webapp page tutao/tutanota
2 participants
@charlag @paw-hub