Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App stays in multiselect mode after deleting selected contacts #6507

Closed
5 of 6 tasks
charlag opened this issue Feb 8, 2024 · 0 comments · Fixed by #6554
Closed
5 of 6 tasks

App stays in multiselect mode after deleting selected contacts #6507

charlag opened this issue Feb 8, 2024 · 0 comments · Fixed by #6554
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Milestone
218.240227.0

Comments

@charlag
Copy link
Contributor

charlag commented Feb 8, 2024 •
edited

To Reproduce
Steps to reproduce the behavior:

  1. Go to contacts (mobile layout)
  2. Select multiple contacts
  3. Hit delete
  4. See that no contacts are selected

Expected behavior
Selection is removed after applying action to contacts

v3.112.2

Test notes

  • Try to reproduce, see expected behavior
  • deleting a single contact works as expected
  • deleting with shortcuts works as expected
  • deleting contacts in search view
    • deleting multiple does not stay in multiselect mode
    • deleting single contact works
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Feb 8, 2024
@wrdhub wrdhub self-assigned this Feb 14, 2024
wrdhub added a commit that referenced this issue Feb 14, 2024
@wrdhub
Add selectNone when deleting contacts
730426d 
Adding the onConfirm function to deleteContacts in ContactView.ts is in
line with how mails handle this need
in promptAndDeleteMails

fix #6507
@wrdhub wrdhub mentioned this issue Feb 14, 2024
Merged
murilopereirame pushed a commit that referenced this issue Feb 19, 2024
@wrdhub @murilopereirame
Add selectNone when deleting contacts
475cb61 
Adding the onConfirm function to deleteContacts in ContactView.ts is in
line with how mails handle this need
in promptAndDeleteMails

fix #6507
@charlag charlag added the state:done meets our definition of done label Feb 20, 2024
@charlag charlag added this to the Next Product Team Release milestone Feb 20, 2024
murilopereirame pushed a commit that referenced this issue Feb 23, 2024
@wrdhub @murilopereirame
Add selectNone when deleting contacts
0024713 
Adding the onConfirm function to deleteContacts in ContactView.ts is in
line with how mails handle this need
in promptAndDeleteMails

fix #6507
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@wrdhub @charlag
Add selectNone when deleting contacts
ccd2ffa 
Adding the onConfirm function to deleteContacts in ContactView.ts is in
line with how mails handle this need
in promptAndDeleteMails

fix #6507
murilopereirame pushed a commit that referenced this issue Feb 26, 2024
@wrdhub @murilopereirame
Add selectNone when deleting contacts
d2d70c7 
Adding the onConfirm function to deleteContacts in ContactView.ts is in
line with how mails handle this need
in promptAndDeleteMails

fix #6507
@charlag charlag assigned charlag and unassigned murilopereirame and wrdhub Feb 26, 2024
@charlag charlag mentioned this issue Feb 27, 2024
Closed
@charlag charlag added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label Feb 27, 2024
murilopereirame pushed a commit that referenced this issue Mar 1, 2024
@wrdhub @murilopereirame
Add selectNone when deleting contacts
ba93aae 
Adding the onConfirm function to deleteContacts in ContactView.ts is in
line with how mails handle this need
in promptAndDeleteMails

fix #6507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Projects
None yet
Milestone
218.240227.0
Development

Successfully merging a pull request may close this issue.

Add selectNone when deleting contacts tutao/tutanota
3 participants
@charlag @murilopereirame @wrdhub