Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab order is broken in the event editor #6656

Closed
14 of 17 tasks
rezbyte opened this issue Mar 5, 2024 · 1 comment · Fixed by #6691 or #6817
Closed
14 of 17 tasks

Tab order is broken in the event editor #6656

rezbyte opened this issue Mar 5, 2024 · 1 comment · Fixed by #6691 or #6817
Labels
a11y Accessibility related problems bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Milestone

Comments

@rezbyte
Copy link
Contributor

rezbyte commented Mar 5, 2024

Describe the bug
When navigating the event editor using a keyboard, the tab gets stuck at the 'from' date field and does not move to the time selector next to it. Manually clicking past them and onto the all day checkbox reveals another problem, the tab also gets stuck the 'repeating' drop-down.

To Reproduce
Steps to reproduce the behavior:

  1. Create or edit an event to cause the event editor to open
  2. Try to navigate the event editor using only 'tab' and 'shift + tab'.
  3. See that you get stuck at the aforementioned places.

Expected behavior
You should be able to tab through each interactable input starting from the cancel button and ending at the description continuously.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chromium
  • Version 122

Test Notes

  • The event editor can be tabbed top to bottom without any other button presses
  • The event editor can be tabbed bottom to top without any other button presses
  • The date picker can be controlled by keyboard
    • Tabbing to and pressing the arrow buttons changes the month
    • Tabbing to the selected date allows the focus to be changed with the arrow keys
    • Pressing enter on the focused date sets it as the current date and closes the dialog
    • Pressing space on the focused date sets it as the current date without closing the dialog
    • Pressing escape closes the dialog and returns focus to the input at anytime when inside the date picker
    • Pressing down or alt and down opens the dialog again
    • Using the arrow keys to focus a date outside the month changes the month while still landing on the correct date
    • Pressing home focuses the first day of the month
    • Pressing end focuses the last day of the month
    • Pressing Page Up goes to the previous month
    • Pressing Page Down goes to the next month
    • Pressing Page Up while holding shift goes to the previous year
    • Pressing Page Down while holding shift goes to the next year
  • Screen readers announce the date picker the same as the OS's native date picker
@rezbyte rezbyte added bug broken functionality, usability problems, unexpected errors a11y Accessibility related problems labels Mar 5, 2024
@rezbyte rezbyte self-assigned this Mar 11, 2024
@charlag charlag added the state:done meets our definition of done label Mar 13, 2024
@charlag charlag added this to the 220.240321.0+ milestone Mar 25, 2024
@wrdhub wrdhub self-assigned this Apr 2, 2024
@wrdhub
Copy link
Contributor

wrdhub commented Apr 2, 2024

Here is what I noticed while testing:

  • tab to month controls, change month with enter. Cannot select day (tab goes to time, and arrows keys do not work)
  • if there is a one day in the first/last week of the month home/end will only go to the 2nd/next to last day of the month (can test with September 2024, it has both! Dec 2024 has the 1st on its own week, and March 2025 has the 31st on its own)

@wrdhub wrdhub added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label Apr 2, 2024
@wrdhub wrdhub removed their assignment Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related problems bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Projects
None yet
3 participants