Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot pick a day via keyboard after changing month on the DatePicker #6816

Closed
3 tasks
rezbyte opened this issue Apr 3, 2024 · 0 comments · Fixed by #6817
Closed
3 tasks

Cannot pick a day via keyboard after changing month on the DatePicker #6816

rezbyte opened this issue Apr 3, 2024 · 0 comments · Fixed by #6817
Assignees
@rezbyte
Labels
dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) state:done meets our definition of done
Milestone
220.240403.0

Comments

@rezbyte
Copy link
Contributor

rezbyte commented Apr 3, 2024 •
edited
Loading

Describe the bug
Changing the month on the DatePicker removes any focusable day.

To Reproduce
Steps to reproduce the behavior:

  1. Tab to the date picker.
  2. Tab to the forward arrow button.
  3. Press enter.
  4. Try to tab to the day section.

Expected behavior
After changing the month via the arrow buttons, pressing tab from the next button moves to a day.

Additional context
Originally reported by @wrdhub.
Note that the other problem mentioned is also handled by #6817.

Test notes

  • Pressing Home on September 2024 focuses the 1st.
  • Pressing End on September 2024 focuses the 30th.
  • Changing the month via the arrow buttons causes the first day of the month to become tabbable.
@rezbyte rezbyte added the dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) label Apr 3, 2024
@rezbyte rezbyte added this to the 220.240327.0 milestone Apr 3, 2024
@rezbyte rezbyte self-assigned this Apr 3, 2024
rezbyte added a commit that referenced this issue Apr 3, 2024
@rezbyte
Fix the DatePicker's day becoming untabbable when changing the month
04618cc 
This makes the first day of the month tabbable if the selected date is
not in the same month.

Closes #6816.
@rezbyte rezbyte mentioned this issue Apr 3, 2024
Merged
@murilopereirame murilopereirame added the state:done meets our definition of done label Apr 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 3, 2024
@rezbyte
Fix the DatePicker focusing the wrong days (#6817)
5354a6f 
* Fix the `DatePicker`'s day becoming untabbable when changing the month

This makes the first day of the month tabbable if the selected date is
not in the same month.

Closes #6816.

* Fix the Home and End buttons focusing the wrong day on the `DatePicker`
murilopereirame pushed a commit that referenced this issue Apr 18, 2024
@rezbyte @murilopereirame
Fix the DatePicker focusing the wrong days (#6817)
8b57dad 
* Fix the `DatePicker`'s day becoming untabbable when changing the month

This makes the first day of the month tabbable if the selected date is
not in the same month.

Closes #6816.

* Fix the Home and End buttons focusing the wrong day on the `DatePicker`
murilopereirame pushed a commit that referenced this issue Apr 18, 2024
@rezbyte @murilopereirame
Fix the DatePicker focusing the wrong days (#6817)
c4ae980 
* Fix the `DatePicker`'s day becoming untabbable when changing the month

This makes the first day of the month tabbable if the selected date is
not in the same month.

Closes #6816.

* Fix the Home and End buttons focusing the wrong day on the `DatePicker`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezbyte rezbyte

Labels
dev bug unpublished bugs, found during our development/test cycle (excluded from release notes) state:done meets our definition of done
Projects
None yet
Milestone
220.240403.0
Development

Successfully merging a pull request may close this issue.

Fix the DatePicker focusing the wrong days tutao/tutanota
2 participants
@murilopereirame @rezbyte