Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-editable events are draggable on Calendar View #6735

Closed
6 tasks done
murilopereirame opened this issue Mar 18, 2024 · 0 comments · Fixed by #6736
Closed
6 tasks done

Non-editable events are draggable on Calendar View #6735

murilopereirame opened this issue Mar 18, 2024 · 0 comments · Fixed by #6736
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
220.240403.0

Comments

@murilopereirame
Copy link
Contributor

murilopereirame commented Mar 18, 2024 •
edited by wrdhub

Description
When the user is invited to an event and accepts the invite, they are able to drag the event on Calendar View changing its date/time, even if they aren't supposed to be able to do it as they aren't the owner of the event.

Expected Behavior
The user isn't able to move the event if they're not the owner of it.

Test Notes

  • Accept an invite for an event
  • Go to Day/Week/Month view
  • Try to drag the event and see that it isn't dragged
  • Dragging your own events still working
  • Dragging events in calendars that you have write permissions still working
  • Dragging events that aren't fully editable doesn't work
@murilopereirame murilopereirame added the bug broken functionality, usability problems, unexpected errors label Mar 18, 2024
@murilopereirame murilopereirame self-assigned this Mar 18, 2024
murilopereirame added a commit that referenced this issue Mar 18, 2024
@murilopereirame
Fix users being able to move non-editable events
ff4deab 
Users were able to move any events belonging to any calendar that
they participate. This commit adds a verification if they are allowed
to move an event before starting the drag event, preventing it if they
aren't.

fix #6735
@murilopereirame murilopereirame changed the title Non-editable evets are draggable on Calendar View Non-editable events are draggable on Calendar View Mar 18, 2024
@murilopereirame murilopereirame mentioned this issue Mar 18, 2024
Merged
@charlag charlag added the state:done meets our definition of done label Mar 21, 2024
@charlag charlag added this to the 220.240321.0+ milestone Mar 25, 2024
@murilopereirame murilopereirame removed their assignment Mar 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@murilopereirame
Fix Non-editable events are draggable on Calendar View (#6736)
9e6f566 
* Fix users being able to move non-editable events

Users were able to move any events belonging to any calendar that
they participate. This commit adds a verification if they are allowed
to move an event before starting the drag event, preventing it if they
aren't.

fix #6735

* Fix broken tests and add a test for not allowed dragging actions

* Changes after review
@murilopereirame murilopereirame mentioned this issue Apr 2, 2024
Closed
@wrdhub wrdhub self-assigned this Apr 2, 2024
@wrdhub wrdhub added the state:tested We tested it and are about to release it label Apr 2, 2024
@wrdhub wrdhub removed their assignment Apr 2, 2024
@wrdhub wrdhub mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
220.240403.0
Development

Successfully merging a pull request may close this issue.

Fix Non-editable events are draggable on Calendar View tutao/tutanota
3 participants
@charlag @murilopereirame @wrdhub