Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Calendar Events with unparsable alarm trigger time results in misleading error #6753

Closed
1 task done
wrdhub opened this issue Mar 20, 2024 · 0 comments · Fixed by #6756
Closed
1 task done
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Milestone

Comments

@wrdhub
Copy link
Contributor

wrdhub commented Mar 20, 2024

Trying to import a calendar event with an alarm trigger that our parser does not like results in a dialog telling the user the file is unreadable. In reality the file is readable, and the event(s) can be read just fine. It's really just an alarm trigger that is not being read correctly.

We should do one or both of these things:

  1. Import the event and tell the user the alarm is not added.
  2. Improve our alarm trigger parser. We used to have more restricted notification times that I think resulted in the way the parser works, but since added custom times were added I think it should not be so restrictive anymore.

Test notes

  • Import calendar events with notifications, see that they are imported with the correct time.
@wrdhub wrdhub self-assigned this Mar 20, 2024
wrdhub added a commit that referenced this issue Mar 20, 2024
Adds events when importing event if alarm is not properly parsed

fix #6753
wrdhub added a commit that referenced this issue Mar 21, 2024
Adds events when importing event if alarm is not properly parsed

fix #6753
@charlag charlag added the state:done meets our definition of done label Mar 21, 2024
@charlag charlag added this to the 220.240321.0+ milestone Mar 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
Adds events when importing event if alarm is not properly parsed

fix #6753
@murilopereirame murilopereirame added the state:tested We tested it and are about to release it label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants