Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom theme as an option in onboarding wizard #6770

Closed
4 tasks done
bedhub opened this issue Mar 22, 2024 · 1 comment · Fixed by #6785
Closed
4 tasks done

Custom theme as an option in onboarding wizard #6770

bedhub opened this issue Mar 22, 2024 · 1 comment · Fixed by #6785
Labels
goal: mobile integration state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Milestone
220.240403.0

Comments

@bedhub
Copy link
Contributor

bedhub commented Mar 22, 2024 •
edited by murilopereirame

When there is a custom theme configured for my account i want that it should appear in the theme selector of the onboarding dialog so that my custom theme applies.

AC

  • In case there is a custom theme available the onboarding page should containing an additional entry for that theme displaying the whitelabel domain.
  • There is no dialog asking to apply the detected custom theme

Test Notes

Test on Android & iOS.

  • When not using a whitelabel account, no custom themes are displayed.
  • When using a whitelabel account, custom themes are displayed as domain names.
  • The dialog does not break even with a large number of themes.
  • Changing the colours in the whitelabel theme causes the theme in the whitelabel accounts to be updated on log in.
@charlag charlag changed the title configure custom theme in onboading flow Custom theme as an option in onboarding wizard Mar 25, 2024
@rezbyte rezbyte self-assigned this Mar 25, 2024
rezbyte added a commit that referenced this issue Mar 25, 2024
@rezbyte
WIP Add the custom themes to the themes page of the onboarding wizard
6f6d926 
Closes #6770.
rezbyte added a commit that referenced this issue Mar 26, 2024
@rezbyte
Add the custom themes to the themes page of the onboarding wizard
7f4303b 
Closes #6770.
rezbyte added a commit that referenced this issue Mar 26, 2024
@rezbyte
Add the custom themes to the themes page of the onboarding wizard
a5edbad 
Closes #6770.
@rezbyte rezbyte mentioned this issue Mar 26, 2024
Merged
rezbyte added a commit that referenced this issue Mar 26, 2024
@rezbyte
Add the custom themes to the themes page of the onboarding wizard
fd1e169 
Closes #6770.
@charlag charlag added the state:done meets our definition of done label Mar 26, 2024
@murilopereirame murilopereirame added this to the 220.240321.0+ milestone Mar 27, 2024
murilopereirame pushed a commit that referenced this issue Mar 27, 2024
@rezbyte @murilopereirame
Add the custom themes to the themes page of the onboarding wizard
b420ae4 
Closes #6770.
github-merge-queue bot pushed a commit that referenced this issue Mar 27, 2024
@rezbyte
Add the custom themes to the themes page of the onboarding wizard (#6785
40610dc 
)

Closes #6770.
@murilopereirame murilopereirame self-assigned this Mar 27, 2024
@murilopereirame
Copy link
Contributor

On Android one of the whitelabel themes is missing and to show the first one, I had to trigger the wizard several times through the about dialog
Screenshot_20240327_174005_Tuta-Test
Screenshot_20240327_174012_Tuta-Test

@murilopereirame murilopereirame added the state:tested-with-comments Issue has been tested but some issues were found and needs review. label Mar 27, 2024
@murilopereirame murilopereirame mentioned this issue Mar 27, 2024
Closed
1 task
@murilopereirame murilopereirame removed their assignment Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
goal: mobile integration state:done meets our definition of done state:tested-with-comments Issue has been tested but some issues were found and needs review.
Projects
None yet
Milestone
220.240403.0
Development

Successfully merging a pull request may close this issue.

Add the custom themes to the themes page of the onboarding flow tutao/tutanota
4 participants
@charlag @bedhub @murilopereirame @rezbyte