Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening the news as an external user causes an error #6845

Closed
2 tasks done
rezbyte opened this issue Apr 10, 2024 · 0 comments · Fixed by #6858
Closed
2 tasks done

Opening the news as an external user causes an error #6845

rezbyte opened this issue Apr 10, 2024 · 0 comments · Fixed by #6858
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Milestone
227.240426.0

Comments

@rezbyte
Copy link
Contributor

rezbyte commented Apr 10, 2024 •
edited by mpfau

Describe the bug
Opening the news badge as an external user causes an error to appear.

To Reproduce
Steps to reproduce the behavior:

  1. Send an encrypted email from a Tuta Mail account to an external email address.
  2. Sign into the external email address.
  3. Click on the link in the notification email.
  4. Sign into the external user.
  5. Click on the news button.
  6. See the error that appears.

Expected behavior
The news button to not be visible.

Additional context

Client: Browser
Type: EXTERNAL
Tutanota version: 220.240408.0
Timestamp (UTC): Wed, 10 Apr 2024 12:15:44 GMT
User agent:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
NotAuthorizedError
Error message: 403: Nv6vpB8----0 | GET /rest/sys/customer/NiFabxI--3-0
Stacktrace:
NotAuthorizedError: 403: Nv6vpB8----0 | GET /rest/sys/customer/NiFabxI--3-0

Test notes

Test on any platform.

  • The news icon button does not appear when logged in as an external user.
  • The news icon button appears when logged in as an internal user.
@rezbyte rezbyte added the bug broken functionality, usability problems, unexpected errors label Apr 10, 2024
@rezbyte rezbyte self-assigned this Apr 12, 2024
rezbyte added a commit that referenced this issue Apr 12, 2024
@rezbyte
Fix the news button being displayed for external users
545084b 
Closes #6845.
@rezbyte rezbyte mentioned this issue Apr 12, 2024
Merged
@charlag charlag added the state:done meets our definition of done label Apr 15, 2024
@charlag charlag added this to the 222.240415.0 + milestone Apr 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
@rezbyte
Fix the news button being displayed for external users (#6858)
5125168 
* Fix the news button being displayed for external users

Closes #6845.

* Clean up `DrawerMenu.ts`

One less element for the browser to worry about.
@mpfau mpfau added the state:tested We tested it and are about to release it label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Milestone
227.240426.0
Development

Successfully merging a pull request may close this issue.

Fix the news button being displayed for external users tutao/tutanota
3 participants
@mpfau @charlag @rezbyte