Fix issues with temporary login #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first issue is attempting to get last update time in OfflineIndicatorViewModel. It was trying to wait for partial login but unfortunately temporary login is also partial login. We didn't want to just return null in this case as it might get interpreted incorrectly and instead we returned a sum type with the exact case and ignore uninitialized storage in this case. The other issue was with LoginController and LoginListener not properly resetting themselves on logout (e.g. after temporary login) and giving incorrect results. The third issue was with PostLoginActions initializing MailModel for temporary login. If a real login into another account is attempted afterwards it would lead to more errors. To fully solve the problem we should rethink how temporary login affects the rest of the app and perhaps skip most of the things that happen during normal login. fix #4559
vitoreiji
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first issue is attempting to get last update time in OfflineIndicatorViewModel. It was trying to wait for partial login but unfortunately temporary login is also partial login.
We didn't want to just return null in this case as it might get interpreted incorrectly and instead we returned a sum type with the exact case and ignore uninitialized storage in this case.
The other issue was with LoginController and LoginListener not properly resetting themselves on logout (e.g. after temporary login) and giving incorrect results.
The third issue was with PostLoginActions initializing MailModel for temporary login. If a real login into another account is attempted afterwards it would lead to more errors.
To fully solve the problem we should rethink how temporary login affects the rest of the app and perhaps skip most of the things that happen during normal login.
fix #4559