Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Fix offline-related crash #4934

Merged
merged 1 commit into from Jan 16, 2023

Commits on Jan 5, 2023

  1. [ios] Fix offline-related crash

    It seems like the reason for the crash in 4836 is concurrent access
    to the db pointer. When we run into the outdated credentials we close
    the db and it can happen while another operation is running. The crash
    was happening when get() would check that db is open and copy the db
    handle, the db would be closed in the meantime and then get() would
    fail when it would try to use the db. The only way to prevent this is
    to make all db usage serial and we achieve this by using actor. This
    probably impacts the performance because there can be no more concurrent
    calls but we believe that the impact is minimal in practice.
    
    fix #4836
    charlag committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    42ec23f View commit details
    Browse the repository at this point in the history