Tests for CoversationViewModel #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
reviewed
Mar 6, 2023
| const viewModelObject = object<MailViewerViewModel>() | ||
| // @ts-ignore | ||
| viewModelObject.mail = mail | ||
| //when(viewModelObject.isCollapsed()).thenReturn(false) |
| } | ||
|
|
||
| function makeMailModel(mailBoxDetail: MailboxDetail): MailModel { | ||
| return downcast({ |
There was a problem hiding this comment.
I would suggest replacing downcast with as Partial<MailModel> as MailModel
| } | ||
|
|
||
| async function makeViewModel(pMail: Mail): Promise<void> { | ||
| let factory = await viewModelFactory() |
| redraw = async () => { | ||
| // defer to the end of the event loop so that viewModel has correct loading state | ||
| await delay(1) | ||
| console.log("redraw", "finished", viewModel.isFinished(), "offline", viewModel.isConnectionLost()) |
There was a problem hiding this comment.
I would avoid logging, it's spammy
| ) | ||
| }) | ||
|
|
||
| o("only one mail is shown when conversation view option is turned off", async function () { |
There was a problem hiding this comment.
I would rewrite most cases like "when the option is off it only shows selected mail", so like "when … then". At least I think we are trying to do it this way these days?
charlag
reviewed
Mar 6, 2023
|
|
||
| when( | ||
| mailModel.getMailboxDetailsForMail( | ||
| matchers.argThat(function (mail) { |
There was a problem hiding this comment.
does this matcher do anything? did you want to use anything() instead?
charlag
reviewed
Mar 6, 2023
| ) | ||
|
|
||
| const numMailsDisplayed = viewModel.conversationItems().filter((i) => i.type === "mail").length | ||
| o(numMailsDisplayed).equals(conversation.length)( |
There was a problem hiding this comment.
I don't know if just the number is enough, it might be that a wrong email is removed
charlag
approved these changes
Mar 6, 2023
charlag
added
the
state:not-testable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.