Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlobAccessToken expiration check #5240

Merged
merged 1 commit into from Mar 9, 2023

Conversation

vitoreiji
Copy link
Contributor

@vitoreiji vitoreiji commented Mar 9, 2023

Simple fixes that should alleviate the problem.

does not close but is related to #5153

Test notes

  • Open the network tab on dev tools and then upload an attachment
  • Verify that a BlobAccessToken was requested
  • Note down the expiration time for the token (you can see it by looking at the response of the request, it is the expires property. Create a new Date() with this number to see the actual time)
  • Create another blob attachment and see that no BlobAccessToken was requested
  • Create another blob attachment 20 seconds before the expiration time of the first one and see that another token was requested.

@charlag charlag added this to the v3.110.1 milestone Mar 9, 2023
@charlag charlag added this pull request to the merge queue Mar 9, 2023
Merged via the queue into master with commit 8f65610 Mar 9, 2023
@charlag charlag deleted the increase-blob-access-token-safety-margin-1352 branch March 9, 2023 15:45
@wrdhub wrdhub self-assigned this Mar 10, 2023
@wrdhub wrdhub added the state:tested We tested it and are about to release it label Mar 10, 2023
@wrdhub wrdhub removed their assignment Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants